[KDE/Mac] Review Request 122277: Improve the version (and copyright) information display in KDE/KF5 systemsettings

[Yichao Yu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122277/#review74837
-----------------------------------------------------------



CMakeLists.txt
<https://git.reviewboard.kde.org/r/122277/#comment51869>

    Also the indent of the `OUTPUT_STRIP_TRAILING_WHITESPACE` line although it's not a big deal. (Not that the coding style in cmake is a big deal itself though....)


- Yichao Yu


On 一月 27, 2015, 12:21 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122277/
> -----------------------------------------------------------
> 
> (Updated 一月 27, 2015, 12:21 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and Yichao Yu.
> 
> 
> Repository: qtcurve
> 
> 
> Description
> -------
> 
> Configuring QtCurve through the KDE systemsettings application shows version and copyright information that isn't very informative nor up to date.
> 
> This patch appends the git commit tag to the version when building in a git working copy, and also adds the name of the current (main) developer to give credit where credit is due!
> 
> 
> Diffs
> -----
> 
>   qt4/config/qtcurveconfig.cpp f3e010c 
>   qt5/config/qtcurveconfig.cpp 5871ac5 
>   CMakeLists.txt 9bc4c3d 
> 
> Diff: https://git.reviewboard.kde.org/r/122277/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.9.5 against Qt4/KDE (4.14.4), Qt 5.4.0 and GTk2 (all through MacPorts).
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20150127/c0afb533/attachment-0001.html>