[KDE/Mac] OSX/CI: Uses of outdated Q_WS_MAC in KF5 projects

Ian Wadham iandw.au at gmail.com
Thu Jan 22 08:41:40 UTC 2015


Hi Marko,

On 22/01/2015, at 6:57 PM, Marko Käning wrote:

> On 21 Jan 2015, at 10:16 , Marko Käning <mk-lists at email.de> wrote:
> 
>> So, this is the KF5 fodder I’ve spotted so far:
>> ---
>> /Users/marko/WC/KDECI-builds/kf5-qt5/knotifications/src/knotificationmanager.cpp:    #ifndef Q_WS_MAC
> </snip>
> I’ve taken care of the above.

Good work.

Have you had a look in the Frameworks libraries?

There are quite a few Q_WS_MAC[X]* occurrences in kdelibs
for KDE 4, especially in kdeinit and friends, which is where I
noticed them back in July.  So maybe there are some lurking
in Frameworks...

> Project plasma-workspace had it already fixed on branch master (above was 'Plasma/5.1’ branch).
> 
> Project predicate is Qt4/KDE4, so no need to touch it.
> 
> I fixed the other occurences.

Great!

Cheers, Ian W.




More information about the kde-mac mailing list