[KDE/Mac] OSX/CI: Uses of outdated Q_WS_MAC in KF5 projects

Marko Käning mk-lists at email.de
Thu Jan 22 07:57:07 UTC 2015


On 21 Jan 2015, at 10:16 , Marko Käning <mk-lists at email.de> wrote:

> So, this is the KF5 fodder I’ve spotted so far:
> ---
> /Users/marko/WC/KDECI-builds/kf5-qt5/knotifications/src/knotificationmanager.cpp:    #ifndef Q_WS_MAC
> /Users/marko/WC/KDECI-builds/kf5-qt5/konsole/src/Application.cpp:#if defined(Q_WS_MAC)
> /Users/marko/WC/KDECI-builds/kf5-qt5/ktexteditor/src/view/kateviewinternal.cpp:#ifdef Q_WS_MAC
> /Users/marko/WC/KDECI-builds/kf5-qt5/lokalize/src/lokalizemainwindow.cpp:#ifndef Q_WS_MAC
> /Users/marko/WC/KDECI-builds/kf5-qt5/marble/src/apps/marble-kde/marble_part.cpp:    #ifdef Q_WS_MAC
> /Users/marko/WC/KDECI-builds/kf5-qt5/marble/src/lib/marble/QtMarbleConfigDialog.cpp:    #ifdef Q_WS_MAC
> /Users/marko/WC/KDECI-builds/kf5-qt5/plasma-workspace/kglobalaccel/globalshortcutsregistry.cpp:#elif defined(Q_WS_MACX)
> /Users/marko/WC/KDECI-builds/kf5-qt5/plasma-workspace/kglobalaccel/kglobalaccel_mac.cpp:#ifdef Q_WS_MAC
> /Users/marko/WC/KDECI-builds/kf5-qt5/plasma-workspace/kglobalaccel/kglobalaccel_mac.cpp:#endif // !Q_WS_MAC
> /Users/marko/WC/KDECI-builds/kf5-qt5/predicate/Predicate/Tools/Utils.cpp:#ifdef Q_WS_MAC
> /Users/marko/WC/KDECI-builds/kf5-qt5/predicate/Predicate/Tools/Utils.cpp:#ifdef Q_WS_MAC
> ---
> This all needs fixing! Feel free to go for it! ;-)

I’ve taken care of the above.

Project plasma-workspace had it already fixed on branch master (above was 'Plasma/5.1’ branch).

Project predicate is Qt4/KDE4, so no need to touch it.

I fixed the other occurences.


More information about the kde-mac mailing list