[KDE/Mac] Review Request 121992: Add Battery energyFull and energyFullDesign

[Kai Uwe Broulik]

> On Jan. 11, 2015, 9:16 nachm., Ian Wadham wrote:
> > This part of KDE desktop software is not ported to Apple OS X by the MacPorts group. People use Apple's battery-monitoring facility. Thanks anyway, Kai... :-)
> 
> Nicolás Alvarez wrote:
>     Solid battery support isn't just for Plasma's battery indicator. There are applications that disable some stuff if the computer is running on batteries, for example.
> 
> Ian Wadham wrote:
>     Hmmmm! Can you give us some examples of which apps those are, so that we can watch out for them?
>     
>     KDE apps that require behind-the-scenes desktop facilities have been a leading cause of problems in KDE on the Apple OS X platform for several years, but our group on KDE-Mac has already dealt with quite a few during the past year. KDE 4 apps are now integrating much better with the Apple desktop than they did before, and we are working towards KF5/Frameworks and an Apple OS X CI facility on KDE servers.

Guys, this is just a behind the scenes library with no daemon(!) that queries the native OS API for information, so when you ask for battery percentage you get that info the same way, no matter on which platform you are on.


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121992/#review73785
-----------------------------------------------------------


On Jan. 11, 2015, 4:41 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121992/
> -----------------------------------------------------------
> 
> (Updated Jan. 11, 2015, 4:41 nachm.)
> 
> 
> Review request for KDE Software on Mac OS X, kdewin, Solid, and Lukáš Tinkl.
> 
> 
> Repository: solid
> 
> 
> Description
> -------
> 
> To properly calculate cumulative values we need to know the actual Wh values of the batteries (deducing it from the current energy and percentage or capacity produces significant rounding errors).
> 
> 
> Diffs
> -----
> 
>   src/solid/devices/frontend/battery.h 4c3c3f7 
>   src/solid/devices/frontend/battery.cpp 7b95fc9 
>   src/solid/devices/ifaces/battery.h 055af62 
>   src/solid/devices/backends/win/winbattery.h 5dfe7c7 
>   src/solid/devices/backends/win/winbattery.cpp 95dbbb3 
>   src/solid/devices/backends/iokit/iokitbattery.h ccf6b20 
>   src/solid/devices/backends/upower/upowerbattery.h 0f0c7b6 
>   src/solid/devices/backends/upower/upowerbattery.cpp 7c1689e 
>   src/solid/devices/backends/hal/halbattery.h 0d91009 
>   src/solid/devices/backends/hal/halbattery.cpp 24dde4b 
>   src/solid/devices/backends/fakehw/fakebattery.h 3066f24 
>   src/solid/devices/backends/fakehw/fakebattery.cpp f90cb76 
> 
> Diff: https://git.reviewboard.kde.org/r/121992/diff/
> 
> 
> Testing
> -------
> 
> energyFull and energyFullDesign report correct values on UPower here. I implemented it for HAL and Windows as well (and IOKit stubs) but I cannot test these, hence adding kdewin and kde-mac groups. Also, we should really add Q_DECL_OVERRIDE all over the place since adding new methods at 5 different places is quite error-prone.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20150111/a1b04075/attachment.html>