<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121992/">https://git.reviewboard.kde.org/r/121992/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Januar 11th, 2015, 9:16 nachm. UTC, <b>Ian Wadham</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This part of KDE desktop software is not ported to Apple OS X by the MacPorts group. People use Apple's battery-monitoring facility. Thanks anyway, Kai... :-)</p></pre>
</blockquote>
<p>On Januar 11th, 2015, 9:21 nachm. UTC, <b>Nicolás Alvarez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Solid battery support isn't just for Plasma's battery indicator. There are applications that disable some stuff if the computer is running on batteries, for example.</p></pre>
</blockquote>
<p>On Januar 11th, 2015, 10:49 nachm. UTC, <b>Ian Wadham</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hmmmm! Can you give us some examples of which apps those are, so that we can watch out for them?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KDE apps that require behind-the-scenes desktop facilities have been a leading cause of problems in KDE on the Apple OS X platform for several years, but our group on KDE-Mac has already dealt with quite a few during the past year. KDE 4 apps are now integrating much better with the Apple desktop than they did before, and we are working towards KF5/Frameworks and an Apple OS X CI facility on KDE servers.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Guys, this is just a behind the scenes library with no daemon(!) that queries the native OS API for information, so when you ask for battery percentage you get that info the same way, no matter on which platform you are on.</p></pre>
<br />
<p>- Kai Uwe</p>
<br />
<p>On Januar 11th, 2015, 4:41 nachm. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Software on Mac OS X, kdewin, Solid, and Lukáš Tinkl.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Jan. 11, 2015, 4:41 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
solid
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To properly calculate cumulative values we need to know the actual Wh values of the batteries (deducing it from the current energy and percentage or capacity produces significant rounding errors).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">energyFull and energyFullDesign report correct values on UPower here. I implemented it for HAL and Windows as well (and IOKit stubs) but I cannot test these, hence adding kdewin and kde-mac groups. Also, we should really add Q_DECL_OVERRIDE all over the place since adding new methods at 5 different places is quite error-prone.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/solid/devices/frontend/battery.h <span style="color: grey">(4c3c3f7)</span></li>
<li>src/solid/devices/frontend/battery.cpp <span style="color: grey">(7b95fc9)</span></li>
<li>src/solid/devices/ifaces/battery.h <span style="color: grey">(055af62)</span></li>
<li>src/solid/devices/backends/win/winbattery.h <span style="color: grey">(5dfe7c7)</span></li>
<li>src/solid/devices/backends/win/winbattery.cpp <span style="color: grey">(95dbbb3)</span></li>
<li>src/solid/devices/backends/iokit/iokitbattery.h <span style="color: grey">(ccf6b20)</span></li>
<li>src/solid/devices/backends/upower/upowerbattery.h <span style="color: grey">(0f0c7b6)</span></li>
<li>src/solid/devices/backends/upower/upowerbattery.cpp <span style="color: grey">(7c1689e)</span></li>
<li>src/solid/devices/backends/hal/halbattery.h <span style="color: grey">(0d91009)</span></li>
<li>src/solid/devices/backends/hal/halbattery.cpp <span style="color: grey">(24dde4b)</span></li>
<li>src/solid/devices/backends/fakehw/fakebattery.h <span style="color: grey">(3066f24)</span></li>
<li>src/solid/devices/backends/fakehw/fakebattery.cpp <span style="color: grey">(f90cb76)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121992/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>