[KDE/Mac] Review Request 120287: [OS X] make kde-workspace build

Martin Gräßlin mgraesslin at kde.org
Sat Sep 20 09:03:47 UTC 2014



> On Sept. 20, 2014, 10:25 vorm., René J.V. Bertin wrote:
> > While we're discussing krdb's function on non-X11 systems:
> > 
> > I seem to recall that the colour theme selector kcm had an effect like it has under X11: applying the new theme to running applications instantly. I can no longer reproduce this. My work on getting this package to OS X has been a very informal approach. It's only been the other day that I realised it could have some value for the transition to KF5, and rounded up everything, tested with the latest kde-workspace version and then made this RR. 
> > So my recollection can be wrong, and it could even be that it's expectable that KDE/Mac doesn't even respect all colour choices for all GUI elements.
> > 
> > For instance, I'm now seeing that simple applications like systemsettings or kwalletmanager ignore (almost) all colour choices, kate and kdevelop use them for the edit views but not lists/frames and digikam uses almost all selected colours (but that app has a builtin theme selector).
> > 
> > I've reverted to kde-workspace 4.11.9 (the one from KDE 4.12.5; MacPorts keeps snapshots one can switch back and forth between) and as far as I can tell those observations are not the result of my changes to krdb.cpp .
> > 
> > Thomas seemed knowledgable about how Qt4 works on OS X; to what extent is this to be expected, and to what extent might we be able to improve this? (If improvement it is on a platform that basically allows only the text selection highlight colour to be customised...)
> > What (missing) things might I look for aside updates to kdeglobal.rc (which I realise I haven't even done yet)?

just wondering: shouldn't the color settings be picked from the MacOS settings?


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120287/#review67024
-----------------------------------------------------------


On Sept. 20, 2014, 12:05 vorm., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120287/
> -----------------------------------------------------------
> 
> (Updated Sept. 20, 2014, 12:05 vorm.)
> 
> 
> Review request for KDE Software on Mac OS X and kde-workspace.
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> A few rather straightforward patches to make the relevant bits of KDE4's kde-workspace build and function on OS X.
> The main interest is having the systemsettings control panel to control the various relevant KDE settings among which desktop search, fonts, colours and even style.
> The oxygen style builds and looks good but shows some updating glitches due to compositing.
> 
> I'm submitting this patch partly in hope it may be useful in bringing kf5-workspace to OS X, one day.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 195f99c 
>   kcontrol/CMakeLists.txt fc666b1 
>   kcontrol/krdb/krdb.cpp 36fc99c 
>   kcontrol/style/CMakeLists.txt d832b20 
>   libs/CMakeLists.txt c0576fe 
> 
> Diff: https://git.reviewboard.kde.org/r/120287/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs git/master, 4.14.1).
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20140920/a75a5f94/attachment.html>


More information about the kde-mac mailing list