<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120287/">https://git.reviewboard.kde.org/r/120287/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 20th, 2014, 10:25 vorm. CEST, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">While we're discussing krdb's function on non-X11 systems:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I seem to recall that the colour theme selector kcm had an effect like it has under X11: applying the new theme to running applications instantly. I can no longer reproduce this. My work on getting this package to OS X has been a very informal approach. It's only been the other day that I realised it could have some value for the transition to KF5, and rounded up everything, tested with the latest kde-workspace version and then made this RR. <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
So my recollection can be wrong, and it could even be that it's expectable that KDE/Mac doesn't even respect all colour choices for all GUI elements.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For instance, I'm now seeing that simple applications like systemsettings or kwalletmanager ignore (almost) all colour choices, kate and kdevelop use them for the edit views but not lists/frames and digikam uses almost all selected colours (but that app has a builtin theme selector).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've reverted to kde-workspace 4.11.9 (the one from KDE 4.12.5; MacPorts keeps snapshots one can switch back and forth between) and as far as I can tell those observations are not the result of my changes to krdb.cpp .</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thomas seemed knowledgable about how Qt4 works on OS X; to what extent is this to be expected, and to what extent might we be able to improve this? (If improvement it is on a platform that basically allows only the text selection highlight colour to be customised...)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
What (missing) things might I look for aside updates to kdeglobal.rc (which I realise I haven't even done yet)?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">just wondering: shouldn't the color settings be picked from the MacOS settings?</p></pre>
<br />
<p>- Martin</p>
<br />
<p>On September 20th, 2014, 12:05 vorm. CEST, René J.V. Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Software on Mac OS X and kde-workspace.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated Sept. 20, 2014, 12:05 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A few rather straightforward patches to make the relevant bits of KDE4's kde-workspace build and function on OS X.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
The main interest is having the systemsettings control panel to control the various relevant KDE settings among which desktop search, fonts, colours and even style.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
The oxygen style builds and looks good but shows some updating glitches due to compositing.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm submitting this patch partly in hope it may be useful in bringing kf5-workspace to OS X, one day.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs git/master, 4.14.1).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(195f99c)</span></li>
<li>kcontrol/CMakeLists.txt <span style="color: grey">(fc666b1)</span></li>
<li>kcontrol/krdb/krdb.cpp <span style="color: grey">(36fc99c)</span></li>
<li>kcontrol/style/CMakeLists.txt <span style="color: grey">(d832b20)</span></li>
<li>libs/CMakeLists.txt <span style="color: grey">(c0576fe)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120287/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>