[KDE/Mac] Review Request 119844: [OS X] backend improvements for kwallet/Keychain integration

[Ian Wadham]

> On Sept. 5, 2014, 5:52 p.m., Marko Käning wrote:
> > tests/KWallet/kwallettest.cpp, line 53
> > <https://git.reviewboard.kde.org/r/119844/diff/4/?file=309940#file309940line53>
> >
> >     Are whitespace changes like this introduced by running the sources through krazy and thus comply with the KDE coding style now?
> 
> René J.V. Bertin wrote:
>     No and I have no idea. This is part of a coding style that is (easily, quickly) readable to/by me ...
> 
> Marko Käning wrote:
>     Hmm... Well, I am afraid that's not accepted then. You need to run krazy on the sources and stick to the KDE coding style.

Indeed. There are two firm conventions in KDE.

One is that library code must adhere to the standard KDE style. The other is that you can use your own style in applications code, BUT, if you are modifying someone else's original code, you must stick to his or her style. These conventions improve readability for the KDE group as a whole and might also make life easier for scripts that trawl through the code from time to time.


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119844/#review65844
-----------------------------------------------------------


On Sept. 5, 2014, 4:21 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119844/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2014, 4:21 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and Valentin Rusu.
> 
> 
> Repository: kwallet
> 
> 
> Description
> -------
> 
> The submitted improvements to kwallet consist of a number of changes to existing files, as well as 2 new files that contain the actual interface to OS X's SecKeychain API.
> 
> With these modifications, KDE wallets are stored in the same location as native OS X keychains, and both can be managed (up to a certain extent) in the OS X Keychain utility as well as the kwalletmanager. In addition, password prompts no longer get posted somewhere in the background.
> 
> 
> Diffs
> -----
> 
>   src/api/KWallet/CMakeLists.txt 9709559 
>   src/api/KWallet/kwallet_mac.cpp d93e5ae 
>   src/api/KWallet/qosxkeychain.h PRE-CREATION 
>   src/api/KWallet/qosxkeychain.cpp PRE-CREATION 
>   tests/KWallet/CMakeLists.txt b155f64 
>   tests/KWallet/kwallettest.cpp 3351a6b 
> 
> Diff: https://git.reviewboard.kde.org/r/119844/diff/
> 
> 
> Testing
> -------
> 
> Testing and development of these was done on OS X 10.6.8 running KDE 4.12.5, which is part of my production environment (https://trac.macports.org/ticket/44473). Since I am not currently able to build (parts of) KF5, porting of my modifications to KF5/KWallet has been done in source only. However, I have good hope that there will be little bugs to review in this request, given the lack of non-esthetic (formatting) modifications to the current kwallet_mac.cpp and kwallettest.cpp.
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20140905/6163d166/attachment.html>