[KDE/Mac] Review Request 120931: [OS X] improvements to KWindowSystem

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120931/#review70388
-----------------------------------------------------------


As the maintainer of the framework in KF5 I would prefer if this work would go into framework and not increase the gap between the 4.x and the 5.x version even more.

Further more my understanding is that 4.x is done on feature side. 14.12 is already feature frozen and my understanding is that this was the last feature release for 4.x all together. Thus I think this new feature (yes working support on OSX is a feature) cannot be added to the 4.x branch. I'm fine with it going in if a kdelibs maintainer (David, Kevin or Kevin) say it's OK to go on.


kdeui/tests/kwindowtest.cpp
<https://git.reviewboard.kde.org/r/120931/#comment49214>

    please note that your test application is fragile as it's based on sleep which is dangerous on an async windowing system.
    
    If you want to perform proper tests have a look at the auto-tests in KWindowSystem framework. I would be very pleased if it gets an OSX port and also the auto-tests adjusted.


- Martin Gräßlin


On Nov. 15, 2014, 12:04 a.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120931/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2014, 12:04 a.m.)
> 
> 
> Review request for KDE Software on Mac OS X and kdelibs.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> This is an attempt to improve the Mac-specific implementation of the `KWindowSystem` class.
> For convenience and future-proofness (and also because I like the language) I converted `kwindowsystem_mac.cpp` to ObjC++, i.e. `kwindowsystem_mac.mm`, and added the AppKit framework in the CMakeFile.
> 
> Much of the code in this file is hardly better than gentle hacking, but that probably concerns the functions that are of least interest on a platform where KDE doesn't do session management.
> 
> I should probably update the "not yet implemented" debug statements (to "unsupported"), and I might have another look at kwindowinfo_mac.cpp too.
> 
> 
> Diffs
> -----
> 
>   kdeui/CMakeLists.txt 1454790 
>   kdeui/tests/kwindowtest.cpp b4012d7 
>   kdeui/windowmanagement/kwindowsystem_mac.cpp 4200237 
>   kdeui/windowmanagement/kwindowsystem_mac_p.h PRE-CREATION 
>   kdeui/windowmanagement/kwindowsystem_macobjc.mm PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120931/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.6.8, mostly with the updated kwindowtest utility (which calls KWindowSystem functions when clicking the Open button in its toolbar).
> Also tested on Mac OS X 10.9.4 rebuilding kdelibs from scratch.
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20141115/1b1d9d9a/attachment-0001.html>