[KDE/Mac] Review Request 120931: [OS X] improvements to KWindowSystem

[René J.V. Bertin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120931/
-----------------------------------------------------------

(Updated Nov. 15, 2014, 12:04 a.m.)


Review request for KDE Software on Mac OS X and kdelibs.


Changes
-------

My previous patch had only been tested with an incremental build. It turns out that the CMake build system does not create moc_XX.cpp files if the `#include "XX.moc"` statement is contained in a ObjC++ file.
This updated patch works around that issue (bug) by moving the ObjC++ code into a separate file and reverting to a pure C++ kwindowsystem_mac.cpp.


Repository: kdelibs


Description
-------

This is an attempt to improve the Mac-specific implementation of the `KWindowSystem` class.
For convenience and future-proofness (and also because I like the language) I converted `kwindowsystem_mac.cpp` to ObjC++, i.e. `kwindowsystem_mac.mm`, and added the AppKit framework in the CMakeFile.

Much of the code in this file is hardly better than gentle hacking, but that probably concerns the functions that are of least interest on a platform where KDE doesn't do session management.

I should probably update the "not yet implemented" debug statements (to "unsupported"), and I might have another look at kwindowinfo_mac.cpp too.


Diffs (updated)
-----

  kdeui/CMakeLists.txt 1454790 
  kdeui/tests/kwindowtest.cpp b4012d7 
  kdeui/windowmanagement/kwindowsystem_mac.cpp 4200237 
  kdeui/windowmanagement/kwindowsystem_mac_p.h PRE-CREATION 
  kdeui/windowmanagement/kwindowsystem_macobjc.mm PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/120931/diff/


Testing (updated)
-------

On OS X 10.6.8, mostly with the updated kwindowtest utility (which calls KWindowSystem functions when clicking the Open button in its toolbar).
Also tested on Mac OS X 10.9.4 rebuilding kdelibs from scratch.


Thanks,

René J.V. Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20141114/2d8095f8/attachment.html>