[Kde-imaging] Review Request 126076: Kipi plugins are using klocalizedstring, but missing to link to KI18n

[Gilles Caulier]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126076/#review88396
-----------------------------------------------------------


Patch sound fine for me...

- Gilles Caulier


On Nov. 15, 2015, 4:47 p.m., Ivan Čukić wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126076/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2015, 4:47 p.m.)
> 
> 
> Review request for Kipi-plugins and Gilles Caulier.
> 
> 
> Repository: kipi-plugins
> 
> 
> Description
> -------
> 
> Apart from missing to link I18n in the plugins, libkipiplugins includes klocalizedstring in a header file (common/libkipiplugins/tools/kpaboutdata.h) while linking to KI18n only privately.
> 
> 
> Diffs
> -----
> 
>   common/libkipiplugins/CMakeLists.txt 811a877 
>   dropbox/CMakeLists.txt 5270e4b 
>   facebook/CMakeLists.txt 09e76b8 
>   flickr/CMakeLists.txt a22ad8b 
>   googleservices/CMakeLists.txt 00361a0 
>   imageshack/CMakeLists.txt 4aa880f 
>   imgur/CMakeLists.txt 13af6f3 
>   piwigo/CMakeLists.txt caac0f8 
>   printimages/CMakeLists.txt 35acba3 
>   rajce/CMakeLists.txt 305710a 
>   remotestorage/CMakeLists.txt faeeb97 
>   smug/CMakeLists.txt 4a5505c 
>   yandexfotki/CMakeLists.txt 196277f 
> 
> Diff: https://git.reviewboard.kde.org/r/126076/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan Čukić
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-imaging/attachments/20151116/a45d0029/attachment.html>