<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126076/">https://git.reviewboard.kde.org/r/126076/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Patch sound fine for me...</p></pre>
<br />
<p>- Gilles Caulier</p>
<br />
<p>On November 15th, 2015, 4:47 p.m. UTC, Ivan Čukić wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Kipi-plugins and Gilles Caulier.</div>
<div>By Ivan Čukić.</div>
<p style="color: grey;"><i>Updated Nov. 15, 2015, 4:47 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kipi-plugins
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Apart from missing to link I18n in the plugins, libkipiplugins includes klocalizedstring in a header file (common/libkipiplugins/tools/kpaboutdata.h) while linking to KI18n only privately.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>common/libkipiplugins/CMakeLists.txt <span style="color: grey">(811a877)</span></li>
<li>dropbox/CMakeLists.txt <span style="color: grey">(5270e4b)</span></li>
<li>facebook/CMakeLists.txt <span style="color: grey">(09e76b8)</span></li>
<li>flickr/CMakeLists.txt <span style="color: grey">(a22ad8b)</span></li>
<li>googleservices/CMakeLists.txt <span style="color: grey">(00361a0)</span></li>
<li>imageshack/CMakeLists.txt <span style="color: grey">(4aa880f)</span></li>
<li>imgur/CMakeLists.txt <span style="color: grey">(13af6f3)</span></li>
<li>piwigo/CMakeLists.txt <span style="color: grey">(caac0f8)</span></li>
<li>printimages/CMakeLists.txt <span style="color: grey">(35acba3)</span></li>
<li>rajce/CMakeLists.txt <span style="color: grey">(305710a)</span></li>
<li>remotestorage/CMakeLists.txt <span style="color: grey">(faeeb97)</span></li>
<li>smug/CMakeLists.txt <span style="color: grey">(4a5505c)</span></li>
<li>yandexfotki/CMakeLists.txt <span style="color: grey">(196277f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126076/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>