[Kde-imaging] libkvkontakte depends on Qt 4.8

[Gilles Caulier]

I just seen that for the second Coverity report, it's relevant of last fix
done by Shourya in FlickrExport tool.

Gilles

2015-05-19 6:34 GMT+02:00 Gilles Caulier <caulier.gilles at gmail.com>:

> Alexander,
>
> I run Coverity Scan too over whole digiKam source code inluding your new libkvkontakte
> implemntation.
>
> Analyzer has found 2 new reports :
>
> ________________________________________________
> ____________________________________________
> 2 new defect(s) introduced to digiKam found with Coverity Scan.
>
> New defect(s) Reported-by: Coverity Scan
> Showing 2 of 2 defect(s)
> _________________________________________________
> ____________________________________________
> *** CID 1299044:  Uninitialized members  (UNINIT_CTOR)
> /mnt/devel/GIT/4.x/extra/libkvkontakte/autotests/test_photos.cpp: 39 in
> TestPhotos::TestPhotos()()
> 33
> 34     using namespace Vkontakte;
> 35
> 36     TestPhotos::TestPhotos()
> 37         : VkTestBase()
> 38     {
> >>>     CID 1299044:  Uninitialized members  (UNINIT_CTOR)
> >>>     Non-static class member "m_photoId" is not initialized in this
> constructor nor in any functions that it calls.
> 39     }
> 40
> 41     void TestPhotos::initTestCase()
> 42     {
> 43         authenticate();
> 44
> _____________________________________________________
> ________________________________________
> *** CID 1299043:  Uninitialized members  (UNINIT_CTOR)
> /mnt/devel/GIT/4.x/extra/kipi-plugins/flickrexport/flickritem.h: 83 in
> KIPIFlickrExportPlugin::FPhotoInfo::FPhotoInfo()()
> 77         {
> 78             is_public    = false;
> 79             is_family    = false;
> 80             is_friend    = false;
> 81             safety_level = FlickrList::SAFE;
> 82             content_type = FlickrList::PHOTO;
> >>>     CID 1299043:  Uninitialized members  (UNINIT_CTOR)
> >>>     Non-static class member "size" is not initialized in this
> constructor nor in any functions that it calls.
> 83         }
> 84
> 85         bool                    is_public;
> 86         bool                    is_friend;
> 87         bool                    is_family;
> 88
> ________________________________________________
> ____________________________________________
>
> To view the defects in Coverity Scan visit,
> https://scan.coverity.com/projects/285?tab=overview
>
> ________________________________________________
> ____________________________________________
>
> Please check and fix your code before to release the library.
>
> Gilles
>
>
>
>
>
> 2015-05-17 23:45 GMT+02:00 Alexander Potashev <aspotashev at gmail.com>:
>
>> Hi everyone,
>>
>> I spent some time to put my library libkvkontakte in order. This
>> included bug fixing, appropriate changes according to the newest
>> version of the VK web API and adding unit tests.
>>
>> Another commit I have just pushed removes the files mpform.* in favor
>> of my own code for HTTP multi-part requests using
>> QHttpMultiPart/QNetworkAccessManager. I moved away from mpform.{cpp,h}
>> because these files are licensed under GPL v2 and thus cannot be mixed
>> in a library that could be licensed under LGPL otherwise.
>> QHttpMultiPart is available since Qt 4.8 and it makes libkvkontakte
>> depend on Qt version 4.8.
>>
>> Because the library libkvkontakte is used by the VK [1] export KIPI
>> plugin and was initially done for it, you may want to know about this
>> new dependency. We can still revert the change for now if it
>> complicates releasing of digiKam too much.
>>
>> Also, I was thinking of releasing libkvkontakte separately from
>> digiKam SC. Is it possible that digiKam SC 4.11.0 or 4.12.0 will
>> depend on libkvkontakte _externally_, or is it too late to intoduce
>> new dependencies in 4.x releases?
>>
>> [1] http://en.wikipedia.org/wiki/VK_(social_networking_website)
>>
>> --
>> Alexander Potashev
>> _______________________________________________
>> Kde-imaging mailing list
>> Kde-imaging at kde.org
>> https://mail.kde.org/mailman/listinfo/kde-imaging
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-imaging/attachments/20150519/38fff6ce/attachment.html>