[Kde-imaging] Review Request 119073: Port to GStreamer 1.0 API / QtGStreamer 1.2

[Gilles Caulier]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119073/#review61588
-----------------------------------------------------------


What's about to support older API ? 
If i understand well your patch you force to use new API without to check which version is available. Right ?
Do we need to use ifdef preprocessor macro around code patched ?

- Gilles Caulier


On July 1, 2014, 6:32 p.m., Andreas Cord-Landwehr wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119073/
> -----------------------------------------------------------
> 
> (Updated July 1, 2014, 6:32 p.m.)
> 
> 
> Review request for Kipi-plugins, Gilles Caulier, Diane Trout, and George Kiagiadakis.
> 
> 
> Bugs: 334089
>     http://bugs.kde.org/show_bug.cgi?id=334089
> 
> 
> Repository: kipi-plugins
> 
> 
> Description
> -------
> 
> Make Kipi-plugins work with the newly released 1.2 version of QtGStreamer (release candidate exists since last week). As QtGStreamer upgrades from the 0.10 API to the 1.0 API of GStreamer, pipelines and plugins have to be adapted.
> 
> 
> Diffs
> -----
> 
>   videoslideshow/manager/encoderdecoder.cpp 23eca8a 
> 
> Diff: https://git.reviewboard.kde.org/r/119073/diff/
> 
> 
> Testing
> -------
> 
> I checked all pipelines with gst-launch-1.0 (as far as I could guess the parameters). But no proper functional testing was done, since I am not fully aware of what kipi-plugins/videoslideshow should do.
> 
> 
> Thanks,
> 
> Andreas Cord-Landwehr
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-imaging/attachments/20140704/59e8e492/attachment.html>