<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119073/">https://git.reviewboard.kde.org/r/119073/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What's about to support older API ?
If i understand well your patch you force to use new API without to check which version is available. Right ?
Do we need to use ifdef preprocessor macro around code patched ?</pre>
<br />
<p>- Gilles Caulier</p>
<br />
<p>On July 1st, 2014, 6:32 p.m. UTC, Andreas Cord-Landwehr wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Kipi-plugins, Gilles Caulier, Diane Trout, and George Kiagiadakis.</div>
<div>By Andreas Cord-Landwehr.</div>
<p style="color: grey;"><i>Updated July 1, 2014, 6:32 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=334089">334089</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kipi-plugins
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make Kipi-plugins work with the newly released 1.2 version of QtGStreamer (release candidate exists since last week). As QtGStreamer upgrades from the 0.10 API to the 1.0 API of GStreamer, pipelines and plugins have to be adapted.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I checked all pipelines with gst-launch-1.0 (as far as I could guess the parameters). But no proper functional testing was done, since I am not fully aware of what kipi-plugins/videoslideshow should do.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>videoslideshow/manager/encoderdecoder.cpp <span style="color: grey">(23eca8a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119073/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>