[Kde-imaging] Review Request 112098: rajceexport: stop crashing when uploaded nothing

[Jiri Slaby]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112098/
-----------------------------------------------------------

(Updated Oct. 28, 2013, 9:19 a.m.)


Status
------

This change has been marked as submitted.


Review request for Kipi-plugins.


Bugs: 307689
    http://bugs.kde.org/show_bug.cgi?id=307689


Repository: kipi-plugins


Description
-------

    When we only open the window and immediately close it, we see:
    0  QDir::fromNativeSeparators (pathName=...) at io/qdir.cpp:854
    1  0x00007ffff6d7f077 in QUrl::fromLocalFile (localFile=...)
        at io/qurl.cpp:6260
    2  0x00007fffce65f0f5 in KIPIRajceExportPlugin::RajceWidget::cancelUpload (
        this=0x197eb80)
        at /usr/src/debug/digikam-3.3.0/extra/kipi-plugins/rajceexport/rajcewidget.cpp:540
    3  0x00007fffce66358d in KIPIRajceExportPlugin::RajceWindow::slotClose (
        this=0x1967e70)
        at /usr/src/debug/digikam-3.3.0/extra/kipi-plugins/rajceexport/rajcewindow.cpp:104
    4  0x00007ffff6dd844f in QMetaObject::activate (sender=0x1967e70,
        m=<optimized out>, local_signal_index=<optimized out>, argv=0x0)
        at kernel/qobject.cpp:3556
    
    It is because the iterator is not initialized yet. So check also
    m_uploadingPhotos before checking the iterator to avoid that problem.


Diffs
-----

  rajceexport/rajcewidget.cpp ff736aff94f7ab6db9c3920124fae725bf6baf8c 

Diff: http://git.reviewboard.kde.org/r/112098/diff/


Testing
-------

Yes, patched, built, tried => fixed. 


Thanks,

Jiri Slaby

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-imaging/attachments/20131028/1b44510d/attachment-0001.html>