<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112098/">http://git.reviewboard.kde.org/r/112098/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Kipi-plugins.</div>
<div>By Jiri Slaby.</div>
<p style="color: grey;"><i>Updated Oct. 28, 2013, 9:19 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=307689">307689</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kipi-plugins
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> When we only open the window and immediately close it, we see:
0 QDir::fromNativeSeparators (pathName=...) at io/qdir.cpp:854
1 0x00007ffff6d7f077 in QUrl::fromLocalFile (localFile=...)
at io/qurl.cpp:6260
2 0x00007fffce65f0f5 in KIPIRajceExportPlugin::RajceWidget::cancelUpload (
this=0x197eb80)
at /usr/src/debug/digikam-3.3.0/extra/kipi-plugins/rajceexport/rajcewidget.cpp:540
3 0x00007fffce66358d in KIPIRajceExportPlugin::RajceWindow::slotClose (
this=0x1967e70)
at /usr/src/debug/digikam-3.3.0/extra/kipi-plugins/rajceexport/rajcewindow.cpp:104
4 0x00007ffff6dd844f in QMetaObject::activate (sender=0x1967e70,
m=<optimized out>, local_signal_index=<optimized out>, argv=0x0)
at kernel/qobject.cpp:3556
It is because the iterator is not initialized yet. So check also
m_uploadingPhotos before checking the iterator to avoid that problem.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, patched, built, tried => fixed. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>rajceexport/rajcewidget.cpp <span style="color: grey">(ff736aff94f7ab6db9c3920124fae725bf6baf8c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112098/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>