[Kde-imaging] [kipi-plugins] panorama/ptoparser/precompiled: Panorama: useless files

Sun Jan 6 19:17:16 UTC 2013

On Sunday 06 January 2013 19:38:17 Benjamin Girault wrote:
> 2013/1/6 Christoph Feck <christoph at maxiom.de>:
> > On Sunday 06 January 2013 18:44:45 Benjamin Girault wrote:
> >> Git commit 6cc33af6d2ce17eaf86a6b4a927d7631db6a5245 by 
Benjamin
> >> Girault. Committed on 06/01/2013 at 18:43.
> >> Pushed by girault into branch 'master'.
> >> 
> >> Panorama: useless files
> >> 
> >> D  +0    -2747 panorama/ptoparser/precompiled/panoParser.c
> >> D  +0    -111  panorama/ptoparser/precompiled/panoParser.h
> >> D  +0    -2191 panorama/ptoparser/precompiled/panoScanner.c
> >> 
> >> http://commits.kde.org/kipi-plugins/6cc33af6d2ce17eaf86a6b4a927d
> >> 763 1db6a5245
> > 
> > I do not think they are useless. Precompiled files are usually
> > explicitely added so that the tools to generate them are not
> > needed.
> 
> I see your point about the requirement for external tools, however,
> maintaining precompiled files is a nightmare, and those tools (Flex
> and Bison) are available on any unix AFAIK, and on Windows.
> 
> > This commit breaks build on my system, where 'flex' and 'bison'
> > are not installed. If those are now indeed required, the cmake
> > checks have to be changed.
> 
> Those checks should have been triggered with my previous commit,
> and there are no reference to those precompiled files in the
> CMakeLists.txt anymore. Have you started with a clean build?
> 
> Best,
> 
> --
> Benjamin.

Attached is a log of cmake run with a clean build.
-------------- next part --------------
-- The C compiler identification is GNU 4.7.2
-- The CXX compiler identification is GNU 4.7.2
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- ----------------------------------------------------------------------------------
-- Starting CMake configuration for: kipi-plugins
-- Looking for Q_WS_X11
-- Looking for Q_WS_X11 - found
-- Looking for Q_WS_WIN
-- Looking for Q_WS_WIN - not found
-- Looking for Q_WS_QWS
-- Looking for Q_WS_QWS - not found
-- Looking for Q_WS_MAC
-- Looking for Q_WS_MAC - not found
-- Found Qt-Version 4.8.4 (using /usr/bin/qmake)
-- Looking for XOpenDisplay in /usr/lib/libX11.so;/usr/lib/libXext.so;/usr/lib/libXft.so;/usr/lib/libXau.so;/usr/lib/libXdmcp.so;/usr/lib/libXpm.so
-- Looking for XOpenDisplay in /usr/lib/libX11.so;/usr/lib/libXext.so;/usr/lib/libXft.so;/usr/lib/libXau.so;/usr/lib/libXdmcp.so;/usr/lib/libXpm.so - found
-- Looking for gethostbyname
-- Looking for gethostbyname - found
-- Looking for connect
-- Looking for connect - found
-- Looking for remove
-- Looking for remove - found
-- Looking for shmat
-- Looking for shmat - found
-- Looking for IceConnectionNumber in ICE
-- Looking for IceConnectionNumber in ICE - found
-- Found X11: /usr/lib/libX11.so
-- Looking for include file pthread.h
-- Looking for include file pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - not found
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - found
-- Found Threads: TRUE  
-- Looking for _POSIX_TIMERS
-- Looking for _POSIX_TIMERS - found
-- Found Automoc4: /local/kde4/bin/automoc4  
-- Found Perl: /usr/bin/perl (found version "5.16.0") 
-- Found Phonon: /local/kde4/include (Required is at least version "4.3.80") 
-- Performing Test _OFFT_IS_64BIT
-- Performing Test _OFFT_IS_64BIT - Failed
-- Performing Test HAVE_FPIE_SUPPORT
-- Performing Test HAVE_FPIE_SUPPORT - Success
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL
-- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL - Success
-- Performing Test __KDE_HAVE_GCC_VISIBILITY
-- Performing Test __KDE_HAVE_GCC_VISIBILITY - Success
-- Found KDE 4.10 include dir: /local/kde4/include
-- Found KDE 4.10 library dir: /local/kde4/lib
-- Found the KDE4 kconfig_compiler preprocessor: /local/kde4/bin/kconfig_compiler
-- Found automoc4: /local/kde4/bin/automoc4
-- Kipi library version required : 2.0.0
-- Check Kipi library in local sub-folder...
-- Check Kipi library using pkg-config...
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.27.1") 
-- checking for module 'libkipi>=2.0.0'
--   found libkipi, version 2.0.0
-- Found KIPI: kipi  
-- Kipi library SO binary version: 10
-- libkipi: Found version 2.0.0 (required: 2.0.0)
-- Check Kexiv2 library in local sub-folder...
-- Check Kexiv2 library using pkg-config...
-- WARNING: you are using the obsolete 'PKGCONFIG' macro, use FindPkgConfig
-- Found libkexiv2 release >= 0.2.0
-- Found libkexiv2: /local/kde4/lib/libkexiv2.so
-- Found JPEG: /usr/lib/libjpeg.so  
-- Found ZLIB: /usr/lib/libz.so (found version "1.2.7") 
-- Found PNG: /usr/lib/libpng.so (found version "1.4.11") 
-- Found TIFF: /usr/lib/libtiff.so (found version "4.0.2") 
-- Check for Kdcraw library in local sub-folder...
-- Check Kdcraw library using pkg-config...
-- checking for module 'libkdcraw'
--   found libkdcraw, version 2.2.0
-- Found libkdcraw release 2.2.0
-- Found libkdcraw: /local/kde4/lib/libkdcraw.so
-- libkdcraw: Found version 2.2.0 (required: 2.2.0)
-- Found EXPAT: /usr/lib/libexpat.so (found version "2.1.0") 
-- Found LibXml2: /usr/lib/libxml2.so (found version "2.7.8") 
-- Found LibXslt: /usr/lib/libxslt.so
-- Found OpenGL: /usr/lib/libGL.so  
-- checking for one of the modules 'libgpod-1.0'
-- libgpod dir: 
-- libgpod lib: 
-- libgpod def: 
-- libgpod ver: 
-- checking for module 'gdk-pixbuf-2.0'
--   package 'gdk-pixbuf-2.0' not found
-- Could NOT find Gdk (missing:  GDK_INCLUDE_DIR GDK_LIBRARIES) 
-- Found GLIB2: /usr/lib/libglib-2.0.so  
-- checking for module 'gobject-2.0'
--   found gobject-2.0, version 2.32.4
-- Found GOBJECT: /usr/lib/libgobject-2.0.so;/usr/lib/libgmodule-2.0.so;/usr/lib/libgthread-2.0.so;/usr/lib/libglib-2.0.so  
-- Found NEPOMUK2_ADDONTOLOGYCLASSES_FILE: /local/kde4/lib/cmake/NepomukCore/Nepomuk2AddOntologyClasses.cmake
-- Found KdepimLibs: /local/kde4/lib/cmake/KdepimLibs/KdepimLibsConfig.cmake  
-- Found QCA2: /usr/lib/libqca.so  
CMake Warning at /local/KDE4/trunk/share/apps/cmake/modules/MacroOptionalFindPackage.cmake:32 (find_package):
  By not providing "FindOpenCV.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "OpenCV", but
  CMake did not find one.

  Could not find a package configuration file provided by "OpenCV" with any
  of the following names:

    OpenCVConfig.cmake
    opencv-config.cmake

  Add the installation prefix of "OpenCV" to CMAKE_PREFIX_PATH or set
  "OpenCV_DIR" to a directory containing one of the above files.  If "OpenCV"
  provides a separate development package or SDK, be sure it has been
  installed.
Call Stack (most recent call first):
  CMakeLists.txt:164 (MACRO_OPTIONAL_FIND_PACKAGE)

-- checking for module 'QJson>=0.5'
--   found QJson, version 0.8.1
-- Found QJSON: /local/kde4/lib/libqjson.so  
-- Check for KGeoMap library in local sub-folder...
-- Check KGeoMap library using pkg-config...
-- checking for one of the modules 'libkgeomap'
-- Found libkgeomap release 2.0.0
-- Found libkgeomap: /local/kde4/lib/libkgeomap.so
-- Check Mediawiki library in local sub-folder...
-- Check Mediawiki library using pkg-config...
-- WARNING: you are using the obsolete 'PKGCONFIG' macro, use FindPkgConfig
-- Found libmediawiki release >= 1.0.0
-- Found libmediawiki: /local/kde4/lib/libmediawiki.so
-- Boost version: 1.49.0
-- Could NOT find FLEX (missing:  FLEX_EXECUTABLE) 
-- Could NOT find BISON (missing:  BISON_EXECUTABLE) 
-- Could NOT find required package HUpnpCore: <http://herqq.org>
-- Could NOT find required package HUpnpAv: <http://herqq.org>
-- Could NOT find ImageMagick (missing:  ImageMagick_MagickCore_LIBRARY ImageMagick_display_EXECUTABLE) 
CMake Warning at /local/KDE4/trunk/share/apps/cmake/modules/MacroOptionalFindPackage.cmake:32 (find_package):
  By not providing "FindQtGStreamer.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "QtGStreamer", but CMake did not find one.

  Could not find a package configuration file provided by "QtGStreamer" with
  any of the following names:

    QtGStreamerConfig.cmake
    qtgstreamer-config.cmake

  Add the installation prefix of "QtGStreamer" to CMAKE_PREFIX_PATH or set
  "QtGStreamer_DIR" to a directory containing one of the above files.  If
  "QtGStreamer" provides a separate development package or SDK, be sure it
  has been installed.
Call Stack (most recent call first):
  CMakeLists.txt:174 (MACRO_OPTIONAL_FIND_PACKAGE)

-- Could NOT find QtKOAuth (missing:  QTKOAUTH_LIBRARIES QTKOAUTH_INCLUDE_DIR) 
-- libkgeomap: Found version 2.0.0
-- Found X11: /usr/lib/libX11.so
-- CMake version: cmake version 2.8.10.2

-- CMake version (cleaned): cmake version 2.8.10.2

-- Try OpenMP C flag = [-fopenmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Success
-- Try OpenMP CXX flag = [-fopenmp]
-- Performing Test OpenMP_FLAG_DETECTED
-- Performing Test OpenMP_FLAG_DETECTED - Success
-- Found OpenMP: -fopenmp  
-- 
-- ----------------------------------------------------------------------------------
--  kipi-plugins 3.0.0 dependencies results   <http://www.digikam.org>
-- 
--  libjpeg library found.................... YES
--  libtiff library found.................... YES
--  libpng library found..................... YES
--  libkipi library found.................... YES
--  libkexiv2 library found.................. YES
--  libkdcraw library found.................. YES
--  libxml2 library found.................... YES (optional)
--  libxslt library found.................... YES (optional)
--  libexpat library found................... YES (optional)
--  native threads support library found..... YES (optional)
--  libopengl library found.................. YES (optional)
--  Qt4 OpenGL module found.................. YES
--  libopencv library found.................. NO  (optional)
--  QJson library found...................... YES (optional)
--  libgpod library found.................... NO  (optional)
--  Gdk library found........................ NO  (optional)
--  libkdepim library found.................. YES (optional)
--  qca2 library found....................... YES (optional)
--  libkgeomap library found................. YES (optional)
--  libmediawiki library found............... YES (optional)
--  libkvkontakte library found.............. YES (optional)
--  boost library found...................... YES (optional)
--  libimagemagick library found............. NO  (optional)
--  libqtgstreamer library found............. NO  (optional)
--  QtKOAuth library found................... NO  (optional)
--  OpenMP library found..................... YES (optional)
--  libX11 library found..................... YES (optional)
--  libksane library found................... YES (optional)
--  Hupnp library found...................... NO  (optional - internal version used instead)
-- 
--  kipi-plugins will be compiled............ YES
--  Shwup will be compiled................... YES (optional)
--  YandexFotki will be compiled............. YES (optional)
--  HtmlExport will be compiled.............. YES (optional)
--  AdvancedSlideshow will be compiled....... YES (optional)
--  ImageViewer will be compiled............. YES (optional)
--  AcquireImages will be compiled........... YES (optional)
--  DNGConverter will be compiled............ YES (optional)
--  RemoveRedEyes will be compiled........... NO  (optional - Look README file for more details about dependencies)
--  Debian Screenshots will be compiled...... YES (optional)
--  Facebook will be compiled................ YES (optional)
--  VKontakte will be compiled............... YES (optional)
--  IpodExport will be compiled.............. NO  (optional - Look README file for more details about dependencies)
--  Calendar will be compiled................ YES (optional)
--  GPSSync will be compiled................. YES (optional)
--  Mediawiki will be compiled............... YES (optional)
--  Panorama will be compiled................ NO  (optional - Look README file for more details about dependencies)
--  VideoSlideshow will be compiled.......... NO  (optional - Look README file for more details about dependencies)
--  Wallpaper will be compiled............... NO  (optional - Look README file for more details about dependencies)
-- ----------------------------------------------------------------------------------
-- 
-- Check if the system is big endian
-- Searching 16 bit integer
-- Looking for sys/types.h
-- Looking for sys/types.h - found
-- Looking for stdint.h
-- Looking for stdint.h - found
-- Looking for stddef.h
-- Looking for stddef.h - found
-- Check size of unsigned short
-- Check size of unsigned short - done
-- Using unsigned short
-- Check if the system is big endian - little endian
CMake Error at panorama/CMakeLists.txt:10 (FLEX_TARGET):
  Unknown CMake command "FLEX_TARGET".

-- Configuring incomplete, errors occurred!