[Kde-imaging] [kipi-plugins] panorama/ptoparser/precompiled: Panorama: useless files

[Benjamin Girault]

2013/1/6 Christoph Feck <christoph at maxiom.de>:
> On Sunday 06 January 2013 18:44:45 Benjamin Girault wrote:
>> Git commit 6cc33af6d2ce17eaf86a6b4a927d7631db6a5245 by Benjamin
>> Girault. Committed on 06/01/2013 at 18:43.
>> Pushed by girault into branch 'master'.
>>
>> Panorama: useless files
>>
>> D  +0    -2747 panorama/ptoparser/precompiled/panoParser.c
>> D  +0    -111  panorama/ptoparser/precompiled/panoParser.h
>> D  +0    -2191 panorama/ptoparser/precompiled/panoScanner.c
>>
>> http://commits.kde.org/kipi-plugins/6cc33af6d2ce17eaf86a6b4a927d763
>> 1db6a5245
>
> I do not think they are useless. Precompiled files are usually
> explicitely added so that the tools to generate them are not needed.

I see your point about the requirement for external tools, however,
maintaining precompiled files is a nightmare, and those tools (Flex
and Bison) are available on any unix AFAIK, and on Windows.

> This commit breaks build on my system, where 'flex' and 'bison' are
> not installed. If those are now indeed required, the cmake checks have
> to be changed.

Those checks should have been triggered with my previous commit, and
there are no reference to those precompiled files in the
CMakeLists.txt anymore. Have you started with a clean build?

Best,

--
Benjamin.