[Kde-imaging] [Bug 286018] Pano Tool and ExpoBlend tool do not work on OS X [patch]

[Ananta Palani]

https://bugs.kde.org/show_bug.cgi?id=286018





--- Comment #44 from Ananta Palani <anantapalani gmail com>  2012-01-20 16:58:02 ---
(In reply to comment #43)
> Thanks for the feedback, I really appreciate it.

You're welcome, thanks for writing the plug-in :)

> (In reply to comment #40)
> > 1. pto2mk.exe crashes when detected (or after detection and a restart of
> > digikam, when panorama creator wizard is first opened)
> 
> You are right, I changed something and introduced somehow a bug that is
> corrected now (I gave "-V" instead of "-h" to pto2mk for testing its
> availability). What do you mean by "pto2mk.exe crashes"? is it the executable
> itself, or also the plugin (and maybe digikam)?

Doesn't crash anymore (pto2mk.exe was crashing)

> > 2. clicking 'change' button browses digikam's working directory, not the
> > directory of the given app
> 
> Done.

There were some problems with how this was implemented. I committed some
changes so that this launches properly on Mac/Windows again. Basically
KUrl(cstr) behaves differently from KUrl(QString) so I made simply made the
paths QStrings before launching. With the former method, the native browser is
not launched, but instead Dolphin is launched, which is inconsistent.

> > 3. relaunch of panorama wizard within a given digikam session does not re-check
> > existance of hugin apps (only after digikam is restarted and the panorama
> > creator reopened does it detect moved or missing apps), so if the hugin is
> > installed/uninstalled/moved while digikam is opened then the panorama app may
> > not notice the change.
> 
> Good point (I didn't thought of that because I'm using the standalone version
> of the plugin for testing). It should be working now.

Unfortunately this is not working :(

> > 4. an 'Error - Preview cannot be processed.' occurs at the 'Preview and
> > Post-Processing' page. This did not happen with code I pulled on 2012-01-11.
> > Could be related to problem 1?
> 
> Is this error still happening with the latest commits?

It was still happening, but I fixed it. The problem was that make could not
find nona. This was because in the .mk file nona app was listed as
'NONA="nona"' and not 'NONA=nona', so the string replace failed. If you still
need the former method on unix then maybe a regex can be used, but be sure to
leave the double-quotes or the windows path won't work properly because it is
highly likely to have a space in it somewhere!

So, there are two problems left.

1. After locating one of the executables, all the remaining executables are not
located automatically in the same path. Instead, each has to be located
individually. This worked before your changes yesterday.

2. If an error occurs at some point in processing, the 'Next' button is still
available.

3. Same problem as 3. above

Almost there!

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.