[Kde-imaging] [Bug 286018] Pano Tool and ExpoBlend tool do not work on OS X [patch]

[benjamin.girault at gmail.com]

https://bugs.kde.org/show_bug.cgi?id=286018





--- Comment #43 from  <benjamin girault gmail com>  2012-01-19 22:20:48 ---
Thanks for the feedback, I really appreciate it.

(In reply to comment #40)
> 1. pto2mk.exe crashes when detected (or after detection and a restart of
> digikam, when panorama creator wizard is first opened)

You are right, I changed something and introduced somehow a bug that is
corrected now (I gave "-V" instead of "-h" to pto2mk for testing its
availability). What do you mean by "pto2mk.exe crashes"? is it the executable
itself, or also the plugin (and maybe digikam)?

> 2. clicking 'change' button browses digikam's working directory, not the
> directory of the given app

Done.

> 3. relaunch of panorama wizard within a given digikam session does not re-check
> existance of hugin apps (only after digikam is restarted and the panorama
> creator reopened does it detect moved or missing apps), so if the hugin is
> installed/uninstalled/moved while digikam is opened then the panorama app may
> not notice the change.

Good point (I didn't thought of that because I'm using the standalone version
of the plugin for testing). It should be working now.

> 4. an 'Error - Preview cannot be processed.' occurs at the 'Preview and
> Post-Processing' page. This did not happen with code I pulled on 2012-01-11.
> Could be related to problem 1?

Is this error still happening with the latest commits?

> As for the suggestion to add default hugin locations for Windows, is there any
> problem if two directories are added? If not, then these would be the two
> default installation locations depending on the 32/64-bit builds:
> 
> #ifdef Q_WS_WIN
>     d->binariesWidget->addDirectory("C:/Program Files/Hugin/bin");
>     d->binariesWidget->addDirectory("C:/Program Files (x86)/Hugin/bin");
> #endif

Done.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.