[Kde-imaging] Re: [kde-artists] [PATCH] GwenView: Proper icon for Go to Previous Image & Go to Next Image

[David Miller]

On Tuesday 30 December 2008 18:26:31 Nuno Pinheiro wrote:
> A Tuesday 30 December 2008 17:31:04, você escreveu:
> > Nuno Pinheiro wrote:
> > > A Tuesday 30 December 2008 15:06:59, você escreveu:
> > >> Nuno Pinheiro wrote:
> > >>> A Tuesday 30 December 2008 08:53:47, James Richard Tyrer escreveu:
> > >>>> The Oxygen team committed new icons: "go-previous-page" &
> > >>>> "go-next-page" and used those names for the two KDE Standard
> > >>>> Actions which GwenView was using.  Apparently they didn't
> > >>>> understand that these two KDE Standard actions were serving two
> > >>>> functions.  Actually, I think it is better that they do not serve
> > >>>> two purposes and that will mean changes to the code that will
> > >>>> require approval of KDE-Core.
> > >>>
> > >>> I dont get your problems most of the time
> > >>
> > >> Shipping a quality product is about attention to detail.  This means
> > >> fixing the little problems.  Some people call this polishing the
> > >> product.  This may not be how you think about things.  This is
> > >> understandable, but it is why artists need an engineer to take care of
> > >> those damn details.
> > >
> > > Plese keep the engeniring arguments out of here, im as much of a
> > > engenier as the next dude with an engeniring degrea, and a professional
> > > engeniring card, plus alot of real life engeniring work.
> >
> > Your statement comes very close to a personal remark, and it is clearly
> > offensive to anyone that has attended engineering college.
> >
> > I went to engineering college.  I am sorry to hear that you resent that
> > and feel the need to make denigrating remarks about it.
>
>  I dont, I just wish you stop pulling out this nonsence argument, remember
> that I am also an engenier.
>
> > >>> but how come you need to use such ofensive language?
> > >>
> > >> There is nothing offensive in what I said and nothing offensive was
> > >> intended -- it is an objective (but brief) description of what
> > >> happened (Note that it is written to a developer that had to change
> > >> his code because the icons your team made were no longer suitable for
> > >> his application).  I think, as I said, that it is a good idea to have
> > >> the page metaphor icons.  However, this did have a side effect that
> > >> apps like GwenView could no longer use those 2 KDE Standard Actions
> > >> because the page metaphor icons were not suitable (e.g. for "Go to
> > >> Next Image" & "Go to Previous Image")
> > >>
> > >>> IRC there was much discussion about that and no good final agreament.
> > >>
> > >> Perhaps.  But, what I am saying is that the final decision didn't take
> > >> this issue into account, not that the final decision was bad -- just
> > >> that things were more complicated because of past usage of the 2 KDE
> > >> Standard icons.
> > >
> > > Presonaly I dont think this icons bring anything new or relevant, to
> > > the ones we have ... its just one more generic icon wen we alrady have
> > > 2 for this type of meening.
> >
> > I realize that you don't understand why this icon is needed.  Yes, we
> > have three icons for next:
> >
> > 	go-next
> > 	go-next-page
> > 	go-next-view
> >
> > The reason that we need all three is that: "go-next-page" can only be
> > used with pages.  It is good for that, but not suitable for other uses.
> >   So, the reason to have both "go-next" and "go-next-view" is that they
> > are not the same.
> >
> > > I will be wayting on GwenView developres opinion on the subject.
> > > But unless some compeling argument is exposed
> >
> > The argument already exists.  From a usability standpoint, it is not a
> > good idea to have the same icon for two different functions on a toolbar
> > or in one of the submenus.  Avoiding this problem requires having
> > different icons.  KDE-3 solved this issue by having two icon for next,
> > but the one which you created is a page metaphor so can not be used for
> > some purposes such as: Go to Next Image.
> >
> > I also point out that the GwenView Developers did NOT want to use:
> > "go-next" or "go-previous" and the page metaphor icons are not suitable
> > for their application.
> >
> > im gona remove this icons.
> >
> > That would be a serious mistake on your part.  Removing someone else's
> > work without good reason is a very serious matter.  We do not work for a
> > company and you are not my boss.  We are all supposed to be peers and
> > collaborate on the project.
>
> As the maintainer of oxygen I can do that, this icons ofer no extra
> valuable meening in my opinion.
>
> > Your collaboration on this issue appears to be your insistence that this
> > icon is not needed.  But the GwenView Developers do need this icon.
> >
> > I am fixing what I regard as a bug.  If you would rather, I will file a
> > bug report, but it is more efficient to simply fix small bugs that I run
> > across.  Please try to understand that this is currently a GwenView
> > issue.
>
> you said it corectly YOU dont, the rest of the team dont. IM whating on the
> gwnview coders hopinioon on the subject.
> The fdesktop naming standard only has one icon for it we alrady have 2
> think 3 is to much refinement.
>
> > OTOH, if you want to suggest an alternate solution for the problem, I
> > would be happy to discuss it with you.
>
> Altrnative for you is anything as long as we create yeat a new icon.

I can see now, with Gwenview's use of the 'move up one directory' button[*] in 
the Go menu, that the normal go-previous and go-next are not an option.

IMHO, the solution is Nuno's -page icons. They fit Gwenview's needs exactly. 
See the attached image, what would you expect happen when you click on the 
previous / next buttons? Move to the previous and next document. It doesn't 
need another, more specific icon.

[*] Not sure why its included though, the breadcrumb list removes the need for 
this. 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: snapshot1.png
Type: image/png
Size: 25413 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kde-imaging/attachments/20081230/bfa31256/attachment-0001.png