[Kde-imaging] [kde-artists] [PATCH] GwenView: Proper icon for Go to Previous Image & Go to Next Image

[James Richard Tyrer]

David Miller wrote:
> On Tuesday 30 December 2008 08:53:47 James Richard Tyrer wrote:
>> The Oxygen team committed new icons: "go-previous-page" &
>> "go-next-page" and used those names for the two KDE Standard
>> Actions which GwenView was using.  Apparently they didn't
>> understand that these two KDE Standard actions were serving two
>> functions.  Actually, I think it is better that they do not serve
>> two purposes and that will mean changes to the code that will
>> require approval of KDE-Core.
>> 
>> I have committed more generic icons "go-*-view" that are not a page
>>  specific metaphor which should work for other uses including
>> GwenView.
> 
> If generic icons are needed, then what is wrong with the current
> go-*,

First, I note that it was a/the GwenView developer that chose not to use 
them, and replaced the "go-*-page" icons with the "media-seek-*" icons. 
  Perhaps it is best to ask Aurélien Gâteau about why he didn't choose 
"go-*" or the "arrow-*" icons and what he thinks about this.

What is wrong with using them is that then you will have the same icons
for different actions on the same menu or toolbar.  This is why KDE-3
had the icons:

	back
	forward

as well as:

	previous
	next

> or even the green arrows used in most other apps?
> 
>> This small patch should fix the problem:

AFA the icons:

	arrow-left
	arrow-right

there is nothing really wrong with using them except that it is my
understanding that these generic arrow icons are deprecated (they do not 
have proper names) and will be dropped as soon as purpose named icons 
are available to replace them.  At least Jakob told me that he intended 
to drop them.

I presume that you know why it is not correct -- not a good idea -- to 
use the media icons.

-- 
JRT