[Kde-imaging] [PATCH] GwenView: Proper icon for Go to Previous Image & Go to Next Image

[James Richard Tyrer]

Aurélien Gâteau wrote:
> James Richard Tyrer wrote:
>> The Oxygen team committed new icons: "go-previous-page" & "go-next-page" 
>> and used those names for the two KDE Standard Actions which GwenView was 
>> using.  Apparently they didn't understand that these two KDE Standard 
>> actions were serving two functions.  Actually, I think it is better that 
>> they do not serve two purposes and that will mean changes to the code 
>> that will require approval of KDE-Core.
>>
>> I have committed more generic icons "go-*-view" that are not a page 
>> specific metaphor which should work for other uses including GwenView.
> 
> While I agree having generic go-*-view icons is a good idea, Gwenview 
> uses media-seek-{backward,forward}, not go-{previous,next}-page, so it 
> is not affected by the icon change.
> Gwenview uses media-seek-* icons to ensure consistency with the 
> play/pause icon in fullscreen mode. For this reason I do not think it is 
> a good idea to commit this patch.
> 
It was my understanding that you were using the media icons because you 
felt correctly (bug 168075) that the "go-*-page" icons were not suitable 
and that the media icons were what was available despite the fact that 
this was not their correct use.

I will have to look into the play/pause issue you mentioned.  Perhaps 
there is an issue there since presentation type uses should probably not 
use the same icons as media players.

However, assignment of icons with the new names is supposed to be based 
on function and I consider it a bug that you are using the 
"media-seek-*" icons since GwenView is not a media player (it does not 
play audio and/or video).  Also, from a usability standpoint, it is not 
a good idea to use these icons for other uses than what their name 
indicates as this can lead to user confusion.

However, it is your application and it is your decision subject only to 
the input of the usability people.  Perhaps you might want to consult 
with usability about this question.

-- 
JRT