[Kde-imaging] [PATCH] GwenView: Proper icon for Go to Previous Image & Go to Next Image

Aurélien Gâteau aurelien.gateau at free.fr
Tue Dec 30 21:29:41 CET 2008


James Richard Tyrer wrote:
> The Oxygen team committed new icons: "go-previous-page" & "go-next-page" 
> and used those names for the two KDE Standard Actions which GwenView was 
> using.  Apparently they didn't understand that these two KDE Standard 
> actions were serving two functions.  Actually, I think it is better that 
> they do not serve two purposes and that will mean changes to the code 
> that will require approval of KDE-Core.
> 
> I have committed more generic icons "go-*-view" that are not a page 
> specific metaphor which should work for other uses including GwenView.

While I agree having generic go-*-view icons is a good idea, Gwenview 
uses media-seek-{backward,forward}, not go-{previous,next}-page, so it 
is not affected by the icon change.
Gwenview uses media-seek-* icons to ensure consistency with the 
play/pause icon in fullscreen mode. For this reason I do not think it is 
a good idea to commit this patch.

Aurélien


More information about the Kde-imaging mailing list