[Kde-imaging] Proposed enhancement to KIPIPlugins::ImagesList

[Gilles Caulier]

2008/12/8 Andi Clemens <andi.clemens at gmx.net>

> Hi all,
>
> On Monday 08 December 2008 05:56:59 Gilles Caulier wrote:
> > 2008/12/7 Aurélien Gâteau <aurelien.gateau at free.fr>
> >
> > > Luka Renko wrote:
> > > > On Sunday 07 December 2008 19:48:57 Aurélien Gâteau wrote:
> > > >> I think the idea is good, but adding another bool to the constructor
> > > >> is not a good idea, IMO. It leads to unreadable code like this:
> > > >>
> > > >> list = new ImagesList(iface, parent, true, false, false, true);
> > > >
> > > > I agree, I just used the way it was already done for other options
> (not
> > >
> > > to
> > >
> > > > invent new way for only single option).
>
> As you mentioned, this was done to be able to set the layout in the ctor,
> because you normally don't change the layout later.
> I have no problem with setters, but I really guess this will be much more
> complicated.


I'm agree with Andi, that for the moment, patch from Luka is fine.

Of course later, api can be improved following KDE4 rules.

Note that there is no binary compatibility here like this widget is include
in kipi-plugins common place and is not shared with the rest of KDE.

Gilles
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-imaging/attachments/20081208/8d097165/attachment.htm