<br><br><div class="gmail_quote">2008/12/8 Andi Clemens <span dir="ltr"><<a href="mailto:andi.clemens@gmx.net">andi.clemens@gmx.net</a>></span><br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi all,<br>
<div class="Ih2E3d"><br>
On Monday 08 December 2008 05:56:59 Gilles Caulier wrote:<br>
> 2008/12/7 Aurélien Gâteau <<a href="mailto:aurelien.gateau@free.fr">aurelien.gateau@free.fr</a>><br>
><br>
> > Luka Renko wrote:<br>
> > > On Sunday 07 December 2008 19:48:57 Aurélien Gâteau wrote:<br>
> > >> I think the idea is good, but adding another bool to the constructor<br>
> > >> is not a good idea, IMO. It leads to unreadable code like this:<br>
> > >><br>
> > >> list = new ImagesList(iface, parent, true, false, false, true);<br>
> > ><br>
> > > I agree, I just used the way it was already done for other options (not<br>
> ><br>
> > to<br>
> ><br>
> > > invent new way for only single option).<br>
<br>
</div>As you mentioned, this was done to be able to set the layout in the ctor,<br>
because you normally don't change the layout later.<br>
I have no problem with setters, but I really guess this will be much more<br>
complicated.</blockquote><div><br>I'm agree with Andi, that for the moment, patch from Luka is fine.<br><br>Of course later, api can be improved following KDE4 rules.<br><br>Note that there is no binary compatibility here like this widget is include in kipi-plugins common place and is not shared with the rest of KDE.<br>
<br>Gilles</div></div><br>