[Kde-imaging] typo in kipi_plugin_metaedit.po

[Caulier Gilles]

Le Samedi 11 Novembre 2006 13:39, Tom Albers a écrit :
> Op za 11 nov 2006 08:39 schreef u:
> > Hi Oliver,
> >
> > In both case, no, because the code is :
> >
> >     setCaption(i18n("%1 (%2/%3) - Edit IPTC Metadata%4")
> >                .arg((*d->currItem).filename())
> >                .arg(d->urls.findIndex(*(d->currItem))+1)
> >                .arg(d->urls.count())
> >                .arg(d->isReadOnly ? i18n(" - (read only)") :
> > QString::null));
> >
> > ...and the string %4 have a space included or is null. Same for Exif
> > stuff.
>
> Hi Gilles,
>
> Above call to i18n is not allowed. A translator only sees "%1 (%2/%3) -
> Edit IPTC Metadata%4" which makes it untranslatable, as they would not know
> where the placeholders stand for. Next to that it is not advisable to use a
> space at the beginning of a 18n, translators often don't see that.
>
> You can better use someting like this:
>
> if (d->isReadOnly)
>  setCaption(i18n("1 is the filename, 2 the current number, 3 the total
> amount", "%1 (%2/%3) - Edit IPTC Metadata - (read only)")
> .arg((*d->currItem).filename())
>                .arg(d->urls.findIndex(*(d->currItem))+1)
>                .arg(d->urls.count()));
> else
>  setCaption(i18n("1 is the filename, 2 the current number, 3 the total
> amount", "%1 (%2/%3) - Edit IPTC Metadata")
>                .arg((*d->currItem).filename())
>                .arg(d->urls.findIndex(*(d->currItem))+1)
>                .arg(d->urls.count()));
>
> It is longer, but at least clear for the translator.
>
> Toma

Hum, there is more simple :

    setCaption(QString("%1 (%2/%3) - %4")
               .arg((*d->currItem).filename())
               .arg(d->urls.findIndex(*(d->currItem))+1)
               .arg(d->urls.count())
               .arg(i18n("Edit EXIF Metadata")) + 
               (d->isReadOnly ? QString(" - ") + i18n("(read only)") : 
QString::null));

Fixed in svn

Gilles