[Kde-imaging] kdeextragear-libs-1/kipi-plugins [POSSIBLY UNSAFE]

Jesper Pedersen blackie at blackie.dk
Sun May 2 16:08:51 CEST 2004


CVS commit by blackie: 

CCMAIL: kde-imaging at kde.org

If you implement application for loading KIPI plugins, then please read
carefully, there are  a number of changes that you need to make to your
application.

For this check in I implemented the comments editor.
This resulted in a number of changes to other parts:

First, KimDaBa should not show this plugin, as it has better way built
in for setting comments - likewise other tools may not want to show it
because they might not have any way to support comments for images.

Therefore KIPI::PluginLoader::PluginLoader does now as first argument take
a QStringList of plugins not to load - the strings written there should be
the Name attribute of the desktop file for the given plugin.

Later today or tomorrow I anticipate to change the plugin loader class even more -
currently it has these instance variables with accessor methods for them:
   List         m_pluginList;
   QStringList  m_pluginNames;
   QStringList  m_libraryNames;

I need to add some extra information for each plugin, so I'd rather have
all the information in a class like:

class PluginInfo {
  QString name;
  QString comment;
  QString path;
  KIPI::Plugin* plugin; 
  // etc
}
This will result in just one list of PluginInfo's that the host apps will
be able to get to, rather than a number of accessor methods as it is now.

Let me know if you have any objections.

Once I've fixed the above I'll make sure that the name is set during
loading, so that we do not have to specify the name twice - which is why
the KIPI::Plugin::id() was removed again (I added it a week ago)

Finally, the comments editor plugin needed to set the description, which is
why the ImageInfoShared classes that host apps implements has been changed
to include a setComment(), setName(), clearAttributes() and addAttributes()
methods.

Cheers
Jesper


  M +1 -1      Makefile.am   1.5
  M +0 -1      acquireimages/plugin_acquireimages.h   1.3
  M +0 -1      calendar/plugin_calendar.h   1.5
  M +0 -1      cdarchiving/plugin_cdarchiving.h   1.3
  M +43 -49    commentseditor/commentseditor.cpp   1.2
  M +12 -10    commentseditor/commentseditor.h   1.2
  M +20 -11    commentseditor/plugin_commentseditor.cpp   1.3 [POSSIBLY UNSAFE: qDebug]
  M +0 -1      commentseditor/plugin_commentseditor.h   1.3
  M +0 -1      findimages/plugin_findimages.h   1.3
  M +0 -1      helloworld/plugin_helloworld.h   1.5
  M +0 -1      imagesgallery/plugin_imagesgallery.h   1.4
  M +0 -1      jpeglossless/plugin_jpeglossless.h   1.3
  M +0 -1      miscsoperations/plugin_miscsoperations.h   1.3
  M +0 -1      mpegencoder/plugin_mpegencoder.h   1.5
  M +0 -1      printwizard/plugin_printwizard.h   1.5
  M +0 -1      rawconverter/plugin_rawconverter.h   1.4
  M +0 -1      slideshow/plugin_slideshow.h   1.3





More information about the Kde-imaging mailing list