Input requested: unused Lokalize menu actions (SoK 2026 Project)

[Tanish]

Hi Finley and Albert,

Thanks for the detailed analysis, i mistakenly included file_open_recent in
my list. It is implemented (line 609 in lokalizemainwindow.cpp). My bad!

As per what I learned about KStandardActions, even though they come from
the KConfigWidgets framework, they still need to be instantiated in the C++
code. Simply having them in the RC file isn't enough for them to work.

I ran a grep search (grep -R -n "KStandardAction") and found that Lokalize
does create quite a few KStandardActions:

   -

   In lokalizemainwindow.cpp: Open, Quit, OpenRecent, Preferences
   -

   In editortab.cpp: Save, SaveAs, Undo, Redo, Find, FindNext, FindPrev,
   Replace, Next, Prior, FirstPage, LastPage, GotoPage, AddBookmark, Spelling
   -

   In projecttab.cpp: Find

But the actions from my original list are nowhere in the C++ code. No
KStandardAction calls for edit_copy, edit_cut, edit_paste, file_print,
file_close, go_back, bookmark_edit, or any of those others.

So yeah , confirmed that all those actions (except file_open_recent and
edit_clear) are actually unimplemented.

Thanks!
Tanish

On Thu, 5 Feb 2026 at 06:17, <fin-w at tutanota.com> wrote:

> Good point actually Albert.
>
> Tanish, I checked e.g. file_open_recent and as Albert says, it's visible
> in the menu when you open Lokalize. I guess some actions are coming from
> https://invent.kde.org/frameworks/kconfigwidgets and so do not need to be
> defined in Lokalize, they only need to be listed in the XML (.rc) file for
> them to work?
>
> You are right though that e.g. file_print doesn't seem to exist in the UI,
> even though this is also defined in KConfigWidgets... I don't understand
> this discrepancy in how the external actions are handled.
> Seems like majority of your actions list are from KConfigWidgets?
> I think only these are custom (but missing the definition in Lokalize as
> well):
> - alttrans_attach
> - odf2xliff
> - showprojectview_action
> - tmquery_do
>
> This command might be useful for checking where a commit contains a
> particular string:
> git log -Galttrans_attach
>
> According to git, in
> https://invent.kde.org/sdk/lokalize/-/commit/0daee3b05ca76dbc896d62ee20017961ece3c80a Nick
> added alttrans_attach, but it was never used. Safe to remove.
> I don't know what I'm looking at with
> https://invent.kde.org/sdk/lokalize/-/commit/309c4d39c3896490f9c636068a370fa31109dfcc but
> it seems like a Kross scripting thing, and Kross was decommissioned a few
> years ago. Safe to remove.
>
> In
> https://invent.kde.org/sdk/lokalize/-/commit/3eb40b51988e88507a9c14f7b32321f591365f4f Nick
> added showprojectview_action as well as its implementation in Lokalize's
> codebase, but the codebase has move on since then. Safe to remove.
>
> I can't tell what tmquery_do is for, it's implemented here
> https://invent.kde.org/sdk/lokalize/-/commit/eb5d6c5b60c94c6c8b3e9ea3718647bbcc82017e
> but only mentioned in three commits and never implemented. Safe to remove.
>
>
>
> Feb 4, 2026, 22:37 by aacid at kde.org:
>
> > El dimecres, 4 de febrer del 2026, a les 20:41:17 (Hora estàndard
> d’Europa
> > central), Tanish va escriure:
> >
> >> Hello KDE i18n team,
> >>
> >> I hope you’re doing well. I’m reviewing Lokalize’s menus and found a
> small
> >> set of actions that are present in the RC (UI) files but not yet
> >> implemented in the C++ code. Before we decide whether to remove them or
> >> consider implementing them, I’d really appreciate your guidance on
> whether
> >> any of these are still useful or desired by translators.
> >>
> >> If any of these would be valuable to keep, please let me know which ones
> >> and why (even a short reply is very helpful):
> >>
> >>  - alttrans_attach
> >>  - bookmark_edit
> >>  - edit_clear
> >>  - edit_copy
> >>  - edit_cut
> >>  - edit_deselect
> >>  - edit_paste
> >>  - edit_select_all
> >>  - file_close
> >>  - file_close_all
> >>  - file_mail
> >>  - file_new
> >>  - file_open_recent
> >>  - file_print
> >>  - file_print_preview
> >>  - file_revert
> >>  - file_revert_all
> >>  - file_save_all
> >>  - go_back
> >>  - go_document_back
> >>  - go_document_forward
> >>  - go_forward
> >>  - go_goto
> >>  - go_goto_line
> >>  - go_home
> >>  - go_up
> >>  - odf2xliff
> >>  - showprojectview_action
> >>  - tmquery_do
> >>  - view_zoom
> >>
> >> Reference: list derived from Lokalize RC files and action registrations
> >> (e.g., editorui.rc, lokalizemainwindowui.rc, scriptsui.rc).
> >>
> >> Thank you for your time and for all the work you do for localization.
> >>
> >> Best regards, *Tanish Kumar* Season of KDE 2026 Participant KDE Invent:
> >> https://invent.kde.org/tanishfr
> >>
> >
> > Are you sure this list is correct?
> >
> > Lokalize uses KStandardAction::openRecent which is file_open_recent for
> > example.
> >
> > Also I am wondering how you expect translators what go_up is supposed to
> be
> > and if they need it or not :D
> >
> > Cheers,
> >  Albert
> >
> >
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-i18n-doc/attachments/20260205/56ad3eaf/attachment.htm>