Review Request 123418: Add X11 guards

Kai Uwe Broulik kde at privat.broulik.de
Wed Feb 8 11:38:34 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123418/
-----------------------------------------------------------

(Updated Feb. 8, 2017, 11:38 vorm.)


Status
------

This change has been discarded.


Review request for Solid, Martin Gräßlin and Nerdopolis Turfwalker.


Bugs: 346341
    https://bugs.kde.org/show_bug.cgi?id=346341


Repository: powerdevil


Description
-------

Improve X11 guards by correcting compile-time checks and adding runtime checks; also don't constantly query QX11Info.


Diffs
-----

  daemon/backends/upower/xrandrbrightness.h 67d44a8 
  daemon/backends/upower/xrandrbrightness.cpp f1cd5a5 
  daemon/kwinkscreenhelpereffect.h 4d0a163 
  daemon/kwinkscreenhelpereffect.cpp dec5d65 

Diff: https://git.reviewboard.kde.org/r/123418/diff/


Testing
-------

Compiles both with and without HAVE_XCB but I don't have a Wayland setup.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20170208/65b63837/attachment-0001.html>


More information about the Kde-hardware-devel mailing list