Review Request 123262: ddccontrol support for PowerDevil

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123262/
-----------------------------------------------------------

(Updated Feb. 8, 2017, 11:38 vorm.)


Status
------

This change has been discarded.


Review request for Solid.


Repository: powerdevil


Description
-------

This allows PowerDevil to use the ddccontrol utility to manipulate brightness of external monitors through Display Data Channel.

It becomes the last link in the fallback chain; it first tries XRandR, then it tries the sysfs helper, and if all that fails it tries to use the ddccontrol utility.

dcccontrol unfortunately doesn't have machine-readable output so I have to take apart its probing output to get the device name and id of the backlight controls. Also it is pretty slow both initializing (kded startup, the helper saves the values and writes directly to the address returned by the initial probing) and setting brightness (that one doesn't block but it can take seconds until your monitor actually changes brightness)


Diffs
-----

  daemon/BackendConfig.cmake 295a8a2 
  daemon/backends/upower/ddc_helper_actions.actions PRE-CREATION 
  daemon/backends/upower/ddchelper.h PRE-CREATION 
  daemon/backends/upower/ddchelper.cpp PRE-CREATION 
  daemon/backends/upower/powerdevilupowerbackend.h 1c4dd59 
  daemon/backends/upower/powerdevilupowerbackend.cpp 87b9cc7 

Diff: https://git.reviewboard.kde.org/r/123262/diff/


Testing
-------

It's working pretty nicely, I can adjust brightness of my desktop monitor through battery monitor and have it automatically dimmed after a timeout.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20170208/b66ab552/attachment.html>