[Kde-hardware-devel] Review Request 121857: Remove lock screen on suspend and use fade effect

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121857/#review73141
-----------------------------------------------------------


There's an issue with the kscreen helper effect itself that it just makes all the windows transparent, you can see through to your desktop during the transition. I tried changing the effect to just turn the brightness down but that doesn't achieve the desired effect for translucent windows like the panels (only the text gets black).
It also makes for an uneasy experience when you have a lot of windows open.

- Kai Uwe Broulik


On Jan. 5, 2015, 12:20 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121857/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2015, 12:20 nachm.)
> 
> 
> Review request for Solid and Martin Gräßlin.
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> This is based on Review 121530 and removes the lock screen on suspend functionality from PowerDevil which will be handled by the lockscreen in Review 119814. It also makes it use the fade effect of Review 121798.
> 
> 
> Diffs
> -----
> 
>   PowerDevilSettings.kcfg cd103c6 
>   daemon/actions/bundled/suspendsession.h 0cc664e 
>   daemon/actions/bundled/suspendsession.cpp 904b4e4 
>   kcmodule/global/GeneralPage.cpp 1f56a6a 
>   kcmodule/global/generalPage.ui 780b701 
> 
> Diff: https://git.reviewboard.kde.org/r/121857/diff/
> 
> 
> Testing
> -------
> 
> Suspending the machine invokes the fade effect and the screen locks, if enabled, both if Logind1 is connected or not (fallback).
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150105/114f7c38/attachment.html>