<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121857/">https://git.reviewboard.kde.org/r/121857/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There's an issue with the kscreen helper effect itself that it just makes all the windows transparent, you can see through to your desktop during the transition. I tried changing the effect to just turn the brightness down but that doesn't achieve the desired effect for translucent windows like the panels (only the text gets black).
It also makes for an uneasy experience when you have a lot of windows open.</p></pre>
<br />
<p>- Kai Uwe Broulik</p>
<br />
<p>On Januar 5th, 2015, 12:20 nachm. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Solid and Martin Gräßlin.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Jan. 5, 2015, 12:20 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
powerdevil
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is based on Review 121530 and removes the lock screen on suspend functionality from PowerDevil which will be handled by the lockscreen in Review 119814. It also makes it use the fade effect of Review 121798.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Suspending the machine invokes the fade effect and the screen locks, if enabled, both if Logind1 is connected or not (fallback).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>PowerDevilSettings.kcfg <span style="color: grey">(cd103c6)</span></li>
<li>daemon/actions/bundled/suspendsession.h <span style="color: grey">(0cc664e)</span></li>
<li>daemon/actions/bundled/suspendsession.cpp <span style="color: grey">(904b4e4)</span></li>
<li>kcmodule/global/GeneralPage.cpp <span style="color: grey">(1f56a6a)</span></li>
<li>kcmodule/global/generalPage.ui <span style="color: grey">(780b701)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121857/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>