[Kde-hardware-devel] Review Request 126146: [XRandRBrightness] Don't call for xrandr if it's not available

Kai Uwe Broulik kde at privat.broulik.de
Sun Dec 13 20:44:46 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126146/
-----------------------------------------------------------

(Updated Dec. 13, 2015, 8:44 p.m.)


Status
------

This change has been marked as submitted.


Review request for Solid and Thomas Lübking.


Changes
-------

Submitted with commit dde0ecce02259a26655737e6674950e2e303bc6f by Kai Uwe Broulik to branch Plasma/5.5.


Bugs: 352462
    https://bugs.kde.org/show_bug.cgi?id=352462


Repository: powerdevil


Description
-------

Check whether the extension is there before calling into it.

Also cache calls to QX11Info::connection() if we're at it.


Diffs
-----

  daemon/backends/upower/xrandrbrightness.cpp 0abcefe 

Diff: https://git.reviewboard.kde.org/r/126146/diff/


Testing
-------

Still works, didn't test without xrandr.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20151213/5f682341/attachment.html>


More information about the Kde-hardware-devel mailing list