[Kde-hardware-devel] Review Request 126146: [XRandRBrightness] Don't call for xrandr if it's not available

[Thomas Lübking]

> On Dec. 9, 2015, 8:47 p.m., Kai Uwe Broulik wrote:
> > Ping

The © calls you (2015) and Lukas (2010) as authors - so if you're ok with the patch, I'd say just push it.
Calling into an extension that's not available is a protocol violation and the patch fixes it correctly - so it's technically ok.

I'd personally not do an unrelated change in the same commit (bad git revert experience ;-) but /me/ doesn't have a word nor cares in this area.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126146/#review89281
-----------------------------------------------------------


On Nov. 23, 2015, 4 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126146/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2015, 4 p.m.)
> 
> 
> Review request for Solid and Thomas Lübking.
> 
> 
> Bugs: 352462
>     https://bugs.kde.org/show_bug.cgi?id=352462
> 
> 
> Repository: powerdevil
> 
> 
> Description
> -------
> 
> Check whether the extension is there before calling into it.
> 
> Also cache calls to QX11Info::connection() if we're at it.
> 
> 
> Diffs
> -----
> 
>   daemon/backends/upower/xrandrbrightness.cpp 0abcefe 
> 
> Diff: https://git.reviewboard.kde.org/r/126146/diff/
> 
> 
> Testing
> -------
> 
> Still works, didn't test without xrandr.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20151209/6e649d01/attachment.html>