[Kde-hardware-devel] Review Request 123256: Hardcode device order

Kai Uwe Broulik kde at privat.broulik.de
Sat Apr 4 18:59:11 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123256/
-----------------------------------------------------------

(Updated April 4, 2015, 6:59 p.m.)


Status
------

This change has been marked as submitted.


Review request for Solid.


Changes
-------

Submitted with commit 6219c8e4877b38962af2e0d5db0f8eaa70c03bb8 by Kai Uwe Broulik to branch master.


Repository: plasma-workspace


Description
-------

Rather than going through the device type enum backwards where Battery comes second to last, hardcode the order of the device types. Otherwise a device that is both a portable media player and a battery (a phone) shows up as "Battery" in device notifier


Diffs
-----

  dataengines/soliddevice/soliddeviceengine.cpp d9aa21c 

Diff: https://git.reviewboard.kde.org/r/123256/diff/


Testing
-------

Phone no longer shows up as Battery, didn't notice unusual behavior


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150404/c90467c1/attachment.html>


More information about the Kde-hardware-devel mailing list