[Kde-hardware-devel] Review Request 123256: Hardcode device order

[Lukáš Tinkl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123256/#review78498
-----------------------------------------------------------

Ship it!


Ship It!

- Lukáš Tinkl


On Dub. 4, 2015, 8:36 odp., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123256/
> -----------------------------------------------------------
> 
> (Updated Dub. 4, 2015, 8:36 odp.)
> 
> 
> Review request for Solid.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Rather than going through the device type enum backwards where Battery comes second to last, hardcode the order of the device types. Otherwise a device that is both a portable media player and a battery (a phone) shows up as "Battery" in device notifier
> 
> 
> Diffs
> -----
> 
>   dataengines/soliddevice/soliddeviceengine.cpp d9aa21c 
> 
> Diff: https://git.reviewboard.kde.org/r/123256/diff/
> 
> 
> Testing
> -------
> 
> Phone no longer shows up as Battery, didn't notice unusual behavior
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20150404/f27730b1/attachment.html>