[Kde-hardware-devel] Review Request 117936: Port daemon from KDELibs4Support

[David Rosca]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117936/
-----------------------------------------------------------

(Updated May 14, 2014, 9:26 p.m.)


Status
------

This change has been marked as submitted.


Review request for Bluedevil and Àlex Fiestas.


Repository: bluedevil


Description
-------

This patch removes all usage of KDELibs4Support in daemon (src/daemon).
All string literals are also wrapped in QLatin1String/QStringLiteral.

There is still one thing that needs to be done - KStandardDirs::findExe is used in BluezAgent to find executables in LIBEXEC dir.
>From the porting guide: QStandardPaths::findExecutable should be used in this case with hardcoded path =  CMAKE_INSTALL_PREFIX "/" LIBEXEC_INSTALL_DIR.

I am not sure what is the best way to do this. 
Add a new compiler -D define flag (probably not), create the define in a generated .h file (which one?) or is there any other way?


Diffs
-----

  CMakeLists.txt ec07744 
  config.h.cmake PRE-CREATION 
  src/daemon/helpers/authorize/CMakeLists.txt e50985a 
  src/daemon/helpers/authorize/authorize.cpp 25b317a 
  src/daemon/helpers/authorize/main.cpp 930ed58 
  src/daemon/helpers/confirmmodechange/CMakeLists.txt ea3b334 
  src/daemon/helpers/confirmmodechange/confirmmodechange.cpp 5f5afed 
  src/daemon/helpers/confirmmodechange/main.cpp c598aab 
  src/daemon/helpers/requestconfirmation/CMakeLists.txt c12da2c 
  src/daemon/helpers/requestconfirmation/main.cpp ffd88ac 
  src/daemon/helpers/requestconfirmation/requestconfirmation.cpp c9b4cbb 
  src/daemon/helpers/requestpin/CMakeLists.txt 742ba01 
  src/daemon/helpers/requestpin/dialogWidget.ui 1714e78 
  src/daemon/helpers/requestpin/main.cpp 49ac215 
  src/daemon/helpers/requestpin/requestpin.h 2a7ff78 
  src/daemon/helpers/requestpin/requestpin.cpp 69549c7 
  src/daemon/kded/BlueDevilDaemon.h fffc21d 
  src/daemon/kded/BlueDevilDaemon.cpp 7a20b5a 
  src/daemon/kded/CMakeLists.txt 9555d44 
  src/daemon/kded/bluezagent.h 6c32688 
  src/daemon/kded/bluezagent.cpp d19375d 
  src/daemon/kded/filereceiver/filereceiver.h 9ac6b6f 
  src/daemon/kded/filereceiver/filereceiver.cpp 67db6aa 
  src/daemon/kded/filereceiver/obexagent.h 0edff42 
  src/daemon/kded/filereceiver/obexagent.cpp 91ade7d 
  src/daemon/kded/filereceiver/receivefilejob.h 655be8d 
  src/daemon/kded/filereceiver/receivefilejob.cpp 0324aa5 
  src/kcmodule/bluedeviltransfer.cpp 5f118cf 
  src/kcmodule/sharedfilesdialog/sharedfilesdialog.cpp a44b16d 
  src/settings/filereceiver.kcfg 457506a 

Diff: https://git.reviewboard.kde.org/r/117936/diff/


Testing
-------


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140514/fc6cc341/attachment.html>