<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117936/">https://git.reviewboard.kde.org/r/117936/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Bluedevil and Àlex Fiestas.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated May 14, 2014, 9:26 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
bluedevil
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch removes all usage of KDELibs4Support in daemon (src/daemon).
All string literals are also wrapped in QLatin1String/QStringLiteral.
There is still one thing that needs to be done - KStandardDirs::findExe is used in BluezAgent to find executables in LIBEXEC dir.
>From the porting guide: QStandardPaths::findExecutable should be used in this case with hardcoded path = CMAKE_INSTALL_PREFIX "/" LIBEXEC_INSTALL_DIR.
I am not sure what is the best way to do this.
Add a new compiler -D define flag (probably not), create the define in a generated .h file (which one?) or is there any other way?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(ec07744)</span></li>
<li>config.h.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/daemon/helpers/authorize/CMakeLists.txt <span style="color: grey">(e50985a)</span></li>
<li>src/daemon/helpers/authorize/authorize.cpp <span style="color: grey">(25b317a)</span></li>
<li>src/daemon/helpers/authorize/main.cpp <span style="color: grey">(930ed58)</span></li>
<li>src/daemon/helpers/confirmmodechange/CMakeLists.txt <span style="color: grey">(ea3b334)</span></li>
<li>src/daemon/helpers/confirmmodechange/confirmmodechange.cpp <span style="color: grey">(5f5afed)</span></li>
<li>src/daemon/helpers/confirmmodechange/main.cpp <span style="color: grey">(c598aab)</span></li>
<li>src/daemon/helpers/requestconfirmation/CMakeLists.txt <span style="color: grey">(c12da2c)</span></li>
<li>src/daemon/helpers/requestconfirmation/main.cpp <span style="color: grey">(ffd88ac)</span></li>
<li>src/daemon/helpers/requestconfirmation/requestconfirmation.cpp <span style="color: grey">(c9b4cbb)</span></li>
<li>src/daemon/helpers/requestpin/CMakeLists.txt <span style="color: grey">(742ba01)</span></li>
<li>src/daemon/helpers/requestpin/dialogWidget.ui <span style="color: grey">(1714e78)</span></li>
<li>src/daemon/helpers/requestpin/main.cpp <span style="color: grey">(49ac215)</span></li>
<li>src/daemon/helpers/requestpin/requestpin.h <span style="color: grey">(2a7ff78)</span></li>
<li>src/daemon/helpers/requestpin/requestpin.cpp <span style="color: grey">(69549c7)</span></li>
<li>src/daemon/kded/BlueDevilDaemon.h <span style="color: grey">(fffc21d)</span></li>
<li>src/daemon/kded/BlueDevilDaemon.cpp <span style="color: grey">(7a20b5a)</span></li>
<li>src/daemon/kded/CMakeLists.txt <span style="color: grey">(9555d44)</span></li>
<li>src/daemon/kded/bluezagent.h <span style="color: grey">(6c32688)</span></li>
<li>src/daemon/kded/bluezagent.cpp <span style="color: grey">(d19375d)</span></li>
<li>src/daemon/kded/filereceiver/filereceiver.h <span style="color: grey">(9ac6b6f)</span></li>
<li>src/daemon/kded/filereceiver/filereceiver.cpp <span style="color: grey">(67db6aa)</span></li>
<li>src/daemon/kded/filereceiver/obexagent.h <span style="color: grey">(0edff42)</span></li>
<li>src/daemon/kded/filereceiver/obexagent.cpp <span style="color: grey">(91ade7d)</span></li>
<li>src/daemon/kded/filereceiver/receivefilejob.h <span style="color: grey">(655be8d)</span></li>
<li>src/daemon/kded/filereceiver/receivefilejob.cpp <span style="color: grey">(0324aa5)</span></li>
<li>src/kcmodule/bluedeviltransfer.cpp <span style="color: grey">(5f118cf)</span></li>
<li>src/kcmodule/sharedfilesdialog/sharedfilesdialog.cpp <span style="color: grey">(a44b16d)</span></li>
<li>src/settings/filereceiver.kcfg <span style="color: grey">(457506a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117936/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>