[Kde-hardware-devel] Review Request 117129: Set auto connection to false by default on shared connection

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117129/#review54416
-----------------------------------------------------------


This review has been submitted with commit 39f35715e235534e4cba5f47a5001167bd4c43ab by Jan Grulich on behalf of Weng Xuetian to branch frameworks.

- Commit Hook


On March 28, 2014, 2:45 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117129/
> -----------------------------------------------------------
> 
> (Updated March 28, 2014, 2:45 a.m.)
> 
> 
> Review request for Solid.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> IMHO, in most case, shared connection is only a temporarily solution for people who just want to use if they need to share. But with auto connection to be true by default, it will make wifi doesn't scan (when connect to adhoc or use ap will pervent wifi scan), since shared connection is always available, this is very inconvinient for wifi user. 
> 
> And IIRC, shared connection without autoconnection enabled by default is also the old beaviour of old nm.
> 
> 
> Diffs
> -----
> 
>   libs/editor/connectiondetaileditor.cpp 83e0734 
> 
> Diff: https://git.reviewboard.kde.org/r/117129/diff/
> 
> 
> Testing
> -------
> 
> work as expected.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140328/6d96ad83/attachment.html>