[Kde-hardware-devel] Review Request 115409: Workaround battery detection at runtime

[Kai Uwe Broulik]

> On March 7, 2014, 12:19 p.m., Christoph Feck wrote:
> > plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml, line 75
> > <https://git.reviewboard.kde.org/r/115409/diff/1/?file=241087#file241087line75>
> >
> >     Removal of this causes two other regressions: bug 331797, bug 331831.
> >     
> >     I re-added the "onDataChanged:" handling and both bugs are gone, but I only have a single battery, so I cannot test if bug 324847 is still fixed.
> 
> Kai Uwe Broulik wrote:
>     Sorry for the inconvenience :-(
>     
>     Will try to test your patch [1] tomorrow.
>     
>     [1] http://bugsfiles.kde.org/attachment.cgi?id=85464
>
> 
> Christoph Feck wrote:
>     Don't worry :) The regressions are minor, and to be honest, I would prefer  to not commit my patch, unless we find a way to get both bug 321823 and the regressions fixed.
> 
> Kai Uwe Broulik wrote:
>     Just tested it, plugged in and out my mouse multiple times and it appears and re-appears, and also the tooltip (which is reported broken in Bug 324847 Comment 19) seems properly updated.
>     
>     Go ahead and push it, thanks for taking care of this! :-)
> 
> Christoph Feck wrote:
>     But then we would get bug 321823 again...

I think showing wrong brightness (0%) is worse than the auto-closing popup with Ac plugged in and battery charged and the thing hidden in the popup.
I'm seeing a lot of posts about this regression on G+ and other sources lately.
So, please push. :/

Plasma Next should fix the Bug 321823 for us at least I guess.


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115409/#review52338
-----------------------------------------------------------


On Feb. 15, 2014, 10:19 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115409/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2014, 10:19 p.m.)
> 
> 
> Review request for Plasma, Solid and Sebastian Kügler.
> 
> 
> Bugs: 324847
>     http://bugs.kde.org/show_bug.cgi?id=324847
> 
> 
> Repository: kde-workspace
> 
> 
> Description
> -------
> 
> For some reason when a new battery appears (eg. mouse plugged in), the battery does not appear right away in the battery monitor. It appears instantly in plasmaengineexplorer, however.
> I am really clueless on to what causes this, so I just throw this patch in for enlightenment as it sort of makes it work. :/
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/batterymonitor/contents/ui/batterymonitor.qml c1c0169 
> 
> Diff: https://git.reviewboard.kde.org/r/115409/diff/
> 
> 
> Testing
> -------
> 
> Has some minor glitches, please see bugreport.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140326/8b9f49df/attachment.html>