[Kde-hardware-devel] Review Request 119381: not find ProvidersList

[Lamarque Souza]

> On July 21, 2014, 11:31 a.m., Lamarque Souza wrote:
> > libs/editor/mobileproviders.cpp, line 100
> > <https://git.reviewboard.kde.org/r/119381/diff/1/?file=291418#file291418line100>
> >
> >     Is this really necessary? Constructing a UTF-8 QString from local8Bit data would give the same result as the original country QString. This looks redundant to me. Can you check if it still works without this change?
> 
> zhang jun wrote:
>     Is necessary. I am very beginning in the Chinese environment, test 3G network card, get less than the list provider. But in the English environment can get to. Later found not to enter the if statement. Directly through the key () get less than country code in the Chinese environment, can only find by QString :: fromLocal8Bit (country.toLocal8Bit (). Data ()).

I need to check if this will not cause regressions in other country names that use accents before commiting this change.


- Lamarque


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119381/#review62769
-----------------------------------------------------------


On July 21, 2014, 8:08 a.m., zhang jun wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119381/
> -----------------------------------------------------------
> 
> (Updated July 21, 2014, 8:08 a.m.)
> 
> 
> Review request for Solid.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> When the system is in Chinese, country.length () is equal to 2, will not get country code. country must be converted to Local8Bit to find the appropriate country code.
> 
> 
> Diffs
> -----
> 
>   libs/editor/mobileproviders.cpp 886d32c 
> 
> Diff: https://git.reviewboard.kde.org/r/119381/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> zhang jun
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140721/f9fea6fc/attachment.html>