<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119381/">https://git.reviewboard.kde.org/r/119381/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 21st, 2014, 11:31 a.m. UTC, <b>Lamarque Souza</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/119381/diff/1/?file=291418#file291418line100" style="color: black; font-weight: bold; text-decoration: underline;">libs/editor/mobileproviders.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QStringList MobileProviders::getProvidersList(QString country, NetworkManager::ConnectionSettings::ConnectionType type)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">100</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">country</span> <span class="o">=</span> <span class="n">mCountries</span><span class="p">.</span><span class="n">key</span><span class="p">(</span><span class="n">country</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">100</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">country</span> <span class="o">=</span> <span class="n">mCountries</span><span class="p">.</span><span class="n">key</span><span class="p">(</span><span class="n"><span class="hl">QString</span></span><span class="o"><span class="hl">::</span></span><span class="n"><span class="hl">fromLocal8Bit</span></span><span class="p"><span class="hl">(</span></span><span class="n">country</span><span class="p"><span class="hl">.</span></span><span class="n"><span class="hl">toLocal8Bit</span></span><span class="p"><span class="hl">().</span></span><span class="n"><span class="hl">data</span></span><span class="p"><span class="hl">())</span>);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is this really necessary? Constructing a UTF-8 QString from local8Bit data would give the same result as the original country QString. This looks redundant to me. Can you check if it still works without this change?</p></pre>
</blockquote>
<p>On July 21st, 2014, 11:55 a.m. UTC, <b>zhang jun</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is necessary. I am very beginning in the Chinese environment, test 3G network card, get less than the list provider. But in the English environment can get to. Later found not to enter the if statement. Directly through the key () get less than country code in the Chinese environment, can only find by QString :: fromLocal8Bit (country.toLocal8Bit (). Data ()).</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I need to check if this will not cause regressions in other country names that use accents before commiting this change.</p></pre>
<br />
<p>- Lamarque</p>
<br />
<p>On July 21st, 2014, 8:08 a.m. UTC, zhang jun wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Solid.</div>
<div>By zhang jun.</div>
<p style="color: grey;"><i>Updated July 21, 2014, 8:08 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-nm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">When the system is in Chinese, country.length () is equal to 2, will not get country code. country must be converted to Local8Bit to find the appropriate country code.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libs/editor/mobileproviders.cpp <span style="color: grey">(886d32c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119381/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>