[Kde-hardware-devel] OSX/MacPorts KDE CI System: Build failed for framework solid

[Kevin Ottens]

Hello,

On Wednesday 02 July 2014 08:33:01 Marko Käning wrote:
> on OSX solid fails to build because of this:
> 
> ---
> /Users/marko/WC/KDECI-builds/solid/src/solid/devices/backends/iokit/iokitdev
> ice.cpp:227:25: error: allocating an object of abstract class type
> 'Solid::Backends::IOKit::Battery' iface = new Battery(this);
>                         ^
> ---

After a quick investigation it looks like the culprit is the commit 
bb2374e19505d5c6a72039a46d55ec3f632192f4. It got reviewed as review number 
117339.

It looks like there's a need to pay more attention to the multi-platform 
aspects of libsolid when reviewing.

Now we have the following choices:
1) Add in the release notes that solid and most of Tier 3 won't build in 
Windows and Mac OS X (aka we failed on the multiplatform promise on first 
release, aka just great for PR);
2) Revert the patch mentioned above and roll a new 5.0 (aka annoy David and 
the packagers[*]);
3) Produce a hot fix which ports the win and iokit backends propery and roll a 
new 5.0 (aka metalworkers should get their ducks in order immediately, then 
annoy David and the packagers[*]).

Please pick one ASAP.

Regards.

[*] Would make for an awesome band's name BTW.
-- 
Kévin Ottens, http://ervin.ipsquad.net

KDAB - proud supporter of KDE, http://www.kdab.com

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20140703/5de5eec3/attachment.sig>