[Kde-hardware-devel] Review Request 121677: Fix mobile connection wizard manual apn setting

[Lamarque Souza]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121677/#review72521
-----------------------------------------------------------



libs/editor/widgets/mobileconnectionwizard.cpp
<https://git.reviewboard.kde.org/r/121677/#comment50567>

    With your changes if mProvidersList->currentItem() is null here there will be a crash in "Confirm Page". That can happen if package mobile-broadband-provider-info is not installed or its files were manually deleted for instance. You should call radioManualProvider->setChecked(true) to prevent that.



libs/editor/widgets/mobileconnectionwizard.cpp
<https://git.reviewboard.kde.org/r/121677/#comment50566>

    The crash is here. mProviders->currentItem() will be a null pointer.



libs/editor/widgets/mobileconnectionwizard.cpp
<https://git.reviewboard.kde.org/r/121677/#comment50563>

    If you remove the separator in Plan's combobox remove this line too.



libs/editor/widgets/mobileconnectionwizard.cpp
<https://git.reviewboard.kde.org/r/121677/#comment50564>

    And this one too. Have you really tested your changes? The way your patch is it will always select the plan before the correct one in the list.


- Lamarque Souza


On Dec. 26, 2014, 7:46 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121677/
> -----------------------------------------------------------
> 
> (Updated Dec. 26, 2014, 7:46 a.m.)
> 
> 
> Review request for Solid and Lukáš Tinkl.
> 
> 
> Repository: plasma-nm
> 
> 
> Description
> -------
> 
> Current problems:
> 1. if user selects manual provider, apn text is not editable.
> 2. if user select "not listed" in apn page, and go back to provider page and go next again, apn text will be editable while it shouldn't.
> 3. a redundant separator if there's on "My plan is not listed...".
> 
> This change reuses slotEnablePlanEditBox function to set mApnText to correct state, and remove a separator if it's manually set provider.
> 
> 
> Diffs
> -----
> 
>   libs/editor/widgets/mobileconnectionwizard.cpp 29ce4f7 
> 
> Diff: https://git.reviewboard.kde.org/r/121677/diff/
> 
> 
> Testing
> -------
> 
> problems above are fixed.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20141226/d384d503/attachment-0001.html>