[Kde-hardware-devel] Review Request 121677: Fix mobile connection wizard manual apn setting

Xuetian Weng wengxt at gmail.com
Fri Dec 26 07:46:04 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121677/
-----------------------------------------------------------

Review request for Solid and Lukáš Tinkl.


Repository: plasma-nm


Description
-------

Current problems:
1. if user selects manual provider, apn text is not editable.
2. if user select "not listed" in apn page, and go back to provider page and go next again, apn text will be editable while it shouldn't.
3. a redundant separator if there's on "My plan is not listed...".

This change reuses slotEnablePlanEditBox function to set mApnText to correct state, and remove a separator if it's manually set provider.


Diffs
-----

  libs/editor/widgets/mobileconnectionwizard.cpp 29ce4f7 

Diff: https://git.reviewboard.kde.org/r/121677/diff/


Testing
-------

problems above are fixed.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20141226/f37da489/attachment.html>


More information about the Kde-hardware-devel mailing list