[Kde-hardware-devel] Review Request 113913: Handle unexpected error better, plus try to get more debug info.

[Àlex Fiestas]

> On Nov. 17, 2013, 7:33 p.m., Dan Vrátil wrote:
> > backends/xrandr/xrandrconfig.cpp, line 220
> > <http://git.reviewboard.kde.org/r/113913/diff/1/?file=214704#file214704line220>
> >
> >     No reason to print this if we know that currentOutput->currentMode() returns NULL

It will be clearer for me to read, and it doesn't break anything :p


> On Nov. 17, 2013, 7:33 p.m., Dan Vrátil wrote:
> > backends/xrandr/xrandrconfig.cpp, line 252
> > <http://git.reviewboard.kde.org/r/113913/diff/1/?file=214704#file214704line252>
> >
> >     Should we make sure w accidentally don't disable all outputs?

This patch doesn't change that code, we can add a check for that but not in this patch imho.


> On Nov. 17, 2013, 7:33 p.m., Dan Vrátil wrote:
> > backends/xrandr/xrandrconfig.cpp, line 344
> > <http://git.reviewboard.kde.org/r/113913/diff/1/?file=214704#file214704line344>
> >
> >     Don't hardcode the version, use the values defined by CMake (LIBKSCREEN_VERSION IIRC)

In libkscreen we don't pass the version to code, so as this moment we have no way of doing it.

Will add LIBKSCREEN_VERSION in a further patch and modify this, ok?


- Àlex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113913/#review43859
-----------------------------------------------------------


On Nov. 17, 2013, 7:44 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113913/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2013, 7:44 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> -------
> 
> Avoids us crashing KDED, handles null pointer and prints in that case a lot of debug info so we can try to fix this bug... eventually.
> 
> 
> Diffs
> -----
> 
>   backends/xrandr/xrandrconfig.h e2cf455 
>   backends/xrandr/xrandrconfig.cpp 0c59383 
> 
> Diff: http://git.reviewboard.kde.org/r/113913/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20131117/0cc51c98/attachment-0001.html>