[Kde-hardware-devel] Review Request 113913: Handle unexpected error better, plus try to get more debug info.

[Dan Vrátil]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113913/#review43859
-----------------------------------------------------------



backends/xrandr/xrandrconfig.cpp
<http://git.reviewboard.kde.org/r/113913/#comment31494>

    if (!currentMode)



backends/xrandr/xrandrconfig.cpp
<http://git.reviewboard.kde.org/r/113913/#comment31495>

    No reason to print this if we know that currentOutput->currentMode() returns NULL



backends/xrandr/xrandrconfig.cpp
<http://git.reviewboard.kde.org/r/113913/#comment31496>

    Should we make sure w accidentally don't disable all outputs?



backends/xrandr/xrandrconfig.cpp
<http://git.reviewboard.kde.org/r/113913/#comment31497>

    Don't hardcode the version, use the values defined by CMake (LIBKSCREEN_VERSION IIRC)


- Dan Vrátil


On Nov. 17, 2013, 8:18 p.m., Àlex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113913/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2013, 8:18 p.m.)
> 
> 
> Review request for Solid.
> 
> 
> Repository: libkscreen
> 
> 
> Description
> -------
> 
> Avoids us crashing KDED, handles null pointer and prints in that case a lot of debug info so we can try to fix this bug... eventually.
> 
> 
> Diffs
> -----
> 
>   backends/xrandr/xrandrconfig.h e2cf455 
>   backends/xrandr/xrandrconfig.cpp 0c59383 
> 
> Diff: http://git.reviewboard.kde.org/r/113913/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Àlex Fiestas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20131117/a9e376a4/attachment.html>