[Kde-hardware-devel] Review Request 111295: Secrets compability between plasma-nm and networkmanagement

[Daniel Nicoletti]

I'm sorry but IMO this is shouldn't be made this way.
* Do you really want to carry an option to import old secrets?
* Till when this option will be there, Debian users normally jump lots of
releases...
* What if the user decides to use the old applet? It won't work because the
new secrets are in the new format.

IMHO or the same format is used (I don't see why not), or don't import the
secrets at all.

my 2¢


2013/6/29 Jan Grulich <jgrulich at redhat.com>

>    This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111295/
>   Review request for Solid, Lukáš Tinkl and Lamarque Souza.
> By Jan Grulich.
>
> *Updated June 29, 2013, 8:11 a.m.*
> Changes
>
> Updated again, I was too hurried. Anyway, I think I could already push this :)
>
>   Description
>
> As I promised, here is a patch that should fix secrets compatibility between both NM applets. But there is one little difference which is that VPN secrets has "secrets" key in KWallet entry (according to VPN setting property) instead of "VpnSecrets". Everything is done automatically at first start and there is no information about how many secrets were imported etc.
>
>   Diffs (updated)
>
>    - editor/connectioneditor.h (f8fb13f)
>    - editor/connectioneditor.cpp (ee352d2)
>    - kded/secretagent.cpp (dc6f648)
>
> View Diff <http://git.reviewboard.kde.org/r/111295/diff/>
>
> _______________________________________________
> Kde-hardware-devel mailing list
> Kde-hardware-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kde-hardware-devel
>
>


-- 
Daniel Nicoletti

KDE Developer - http://dantti.wordpress.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-hardware-devel/attachments/20130629/ffb9c616/attachment.html>